From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/6] sunxi: video: Add sun6i support
Date: Sun, 16 Nov 2014 11:38:16 +0000 [thread overview]
Message-ID: <1416137896.25454.10.camel@hellion.org.uk> (raw)
In-Reply-To: <1415984088-6800-5-git-send-email-hdegoede@redhat.com>
On Fri, 2014-11-14 at 17:54 +0100, Hans de Goede wrote:
> @@ -177,7 +188,11 @@ sunxi_lcdc_init(void)
> (struct sunxi_lcdc_reg *)SUNXI_LCD0_BASE;
>
> /* Reset off */
> +#ifdef CONFIG_MACH_SUN6I
> + setbits_le32(&ccm->ahb_reset1_cfg, 1 << AHB_RESET_OFFSET_LCD0);
> +#else
> setbits_le32(&ccm->lcd0_ch0_clk_cfg, CCM_LCD_CH0_CTRL_RST);
> +#endif
If you are sure it is correct to no longer frob the lcd clk for sun6i
here (which seems a little odd, might be worth mentioning in the commit
log if it is right) then:
Acked-by: Ian Campbell <ijc@hellion.org.uk>
Ian.
next prev parent reply other threads:[~2014-11-16 11:38 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 16:54 [U-Boot] [PATCH 0/6] sunxi: HDMI (cfb) console support Hans de Goede
2014-11-14 16:54 ` [U-Boot] [PATCH 1/6] sun4i: Rename dram_clk_cfg to dram_clk_gate Hans de Goede
2014-11-16 11:27 ` Ian Campbell
2014-11-14 16:54 ` [U-Boot] [PATCH 2/6] sunxi: Add video pll clock functions Hans de Goede
2014-11-16 11:29 ` Ian Campbell
2014-11-14 16:54 ` [U-Boot] [PATCH 3/6] sunxi: video: Add cfb console driver for sunxi Hans de Goede
2014-11-14 20:17 ` Anatolij Gustschin
2014-11-14 20:24 ` Anatolij Gustschin
2014-11-15 14:58 ` Hans de Goede
2014-11-16 11:35 ` Ian Campbell
2014-11-16 11:39 ` Ian Campbell
2014-11-16 13:15 ` Hans de Goede
2014-11-16 13:34 ` Ian Campbell
2014-11-14 16:54 ` [U-Boot] [PATCH 4/6] sunxi: video: Add sun6i support Hans de Goede
2014-11-14 20:21 ` Anatolij Gustschin
2014-11-16 11:38 ` Ian Campbell [this message]
2014-11-14 16:54 ` [U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support Hans de Goede
2014-11-14 22:22 ` Anatolij Gustschin
2014-11-15 14:58 ` Hans de Goede
2014-11-16 11:50 ` Ian Campbell
2014-11-16 13:52 ` Hans de Goede
2014-11-16 14:38 ` Ian Campbell
2014-11-16 15:11 ` Hans de Goede
2014-11-16 16:11 ` Ian Campbell
2014-11-16 17:19 ` Ian Campbell
2014-11-16 17:52 ` Hans de Goede
2014-11-17 9:58 ` Grant Likely
2014-11-17 10:10 ` Hans de Goede
2014-11-17 10:14 ` Ian Campbell
2014-11-17 15:01 ` Grant Likely
2014-11-14 16:54 ` [U-Boot] [PATCH 6/6] sunxi: Add usb keyboard Kconfig option Hans de Goede
2014-11-16 11:55 ` Ian Campbell
2014-11-16 13:28 ` Hans de Goede
2014-11-16 13:37 ` Ian Campbell
2014-11-16 14:03 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416137896.25454.10.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox