From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ijc@hellion.org.uk>
Date: Mon, 17 Nov 2014 18:54:44 +0000
Subject: [U-Boot] [PATCH 1/5] sun6i: Make dram clk and zq value Kconfig
	options
In-Reply-To: <1416154613-8506-1-git-send-email-hdegoede@redhat.com>
References: <1416154613-8506-1-git-send-email-hdegoede@redhat.com>
Message-ID: <1416250484.25454.28.camel@hellion.org.uk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sun, 2014-11-16 at 17:16 +0100, Hans de Goede wrote:

> +config DRAM_ZQ
> +	int "sun6i dram zq value" if EXPERT
> +	default 123

== 0x7b, which differs from the previous default of 0x78 (not by much,
but still)

> diff --git a/configs/Colombus_defconfig b/configs/Colombus_defconfig
> index bef568d..5e245a3 100644
> --- a/configs/Colombus_defconfig
> +++ b/configs/Colombus_defconfig
> @@ -4,3 +4,5 @@ CONFIG_FDTFILE="sun6i-a31-colombus.dtb"
>  +S:CONFIG_ARCH_SUNXI=y
>  +S:CONFIG_MACH_SUN6I=y
>  +S:CONFIG_TARGET_COLOMBUS=y
> ++S:CONFIG_DRAM_CLK=288
> ++S:CONFIG_DRAM_ZQ=379

Do these actually take affect if CONFIG_EXPERT=n?

Perhaps CONFIG_TARGET_COLOMBUS should select DRAM_CLK == 288 and
DRAM_CLK should be a hidden option?

Ian.