From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: Use "usb start" rather then "run usb_init" for preboot with usb-kbd
Date: Sun, 23 Nov 2014 11:27:05 +0000 [thread overview]
Message-ID: <1416742025.16888.1.camel@hellion.org.uk> (raw)
In-Reply-To: <1416741276-16306-1-git-send-email-hdegoede@redhat.com>
On Sun, 2014-11-23 at 12:14 +0100, Hans de Goede wrote:
> In an effort to avoid usb getting scanned twice when using an usb keyboard,
> and booting from usb, I've set preboot to "run usb_init" in the
> CONFIG_USB_KEYBOARD patch.
>
> This is wrong however, as it causes usb to not be scanned (and the keyboard to
> not be found) if an "env save" is done, since then the env
> contains usb_need_init=false.
>
> This commit fixes this by changing the preboot value to "usb start", so that
> usb gets scanned for a keyboard unconditionally when usb-keyboard support is
> enabled.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Ian Campbell <ijc@hellion.org.uk>
> ---
> include/configs/sunxi-common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
> index fcaa249..3f890b2 100644
> --- a/include/configs/sunxi-common.h
> +++ b/include/configs/sunxi-common.h
> @@ -306,7 +306,7 @@
>
> #ifdef CONFIG_USB_KEYBOARD
> #define CONSOLE_STDIN_SETTINGS \
> - "preboot=run usb_init\0" \
> + "preboot=usb start\0" \
> "stdin=serial,usbkbd\0"
> #else
> #define CONSOLE_STDIN_SETTINGS \
prev parent reply other threads:[~2014-11-23 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 11:14 [U-Boot] [PATCH] sunxi: Use "usb start" rather then "run usb_init" for preboot with usb-kbd Hans de Goede
2014-11-23 11:27 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416742025.16888.1.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox