From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Date: Sun, 23 Nov 2014 11:27:05 +0000 Subject: [U-Boot] [PATCH] sunxi: Use "usb start" rather then "run usb_init" for preboot with usb-kbd In-Reply-To: <1416741276-16306-1-git-send-email-hdegoede@redhat.com> References: <1416741276-16306-1-git-send-email-hdegoede@redhat.com> Message-ID: <1416742025.16888.1.camel@hellion.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, 2014-11-23 at 12:14 +0100, Hans de Goede wrote: > In an effort to avoid usb getting scanned twice when using an usb keyboard, > and booting from usb, I've set preboot to "run usb_init" in the > CONFIG_USB_KEYBOARD patch. > > This is wrong however, as it causes usb to not be scanned (and the keyboard to > not be found) if an "env save" is done, since then the env > contains usb_need_init=false. > > This commit fixes this by changing the preboot value to "usb start", so that > usb gets scanned for a keyboard unconditionally when usb-keyboard support is > enabled. > > Signed-off-by: Hans de Goede Acked-by: Ian Campbell > --- > include/configs/sunxi-common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h > index fcaa249..3f890b2 100644 > --- a/include/configs/sunxi-common.h > +++ b/include/configs/sunxi-common.h > @@ -306,7 +306,7 @@ > > #ifdef CONFIG_USB_KEYBOARD > #define CONSOLE_STDIN_SETTINGS \ > - "preboot=run usb_init\0" \ > + "preboot=usb start\0" \ > "stdin=serial,usbkbd\0" > #else > #define CONSOLE_STDIN_SETTINGS \