* [U-Boot] [PATCH] gpio: intel_ich6: Set correct gpio output value in ich6_gpio_direction_output()
@ 2014-12-07 4:48 Axel Lin
2014-12-07 21:39 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2014-12-07 4:48 UTC (permalink / raw)
To: u-boot
Current code does not set gpio output value in ich6_gpio_direction_output(),
fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/intel_ich6_gpio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/intel_ich6_gpio.c b/drivers/gpio/intel_ich6_gpio.c
index b095d17..92c23ae 100644
--- a/drivers/gpio/intel_ich6_gpio.c
+++ b/drivers/gpio/intel_ich6_gpio.c
@@ -251,6 +251,8 @@ static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset,
struct ich6_bank_priv *bank = dev_get_priv(dev);
u32 tmplong;
+ gpio_set_value(offset, value);
+
tmplong = inl(bank->io_sel);
tmplong &= ~(1UL << offset);
outl(bank->io_sel, tmplong);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] gpio: intel_ich6: Set correct gpio output value in ich6_gpio_direction_output()
2014-12-07 4:48 [U-Boot] [PATCH] gpio: intel_ich6: Set correct gpio output value in ich6_gpio_direction_output() Axel Lin
@ 2014-12-07 21:39 ` Simon Glass
2014-12-11 3:22 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Simon Glass @ 2014-12-07 21:39 UTC (permalink / raw)
To: u-boot
On 6 December 2014 at 21:48, Axel Lin <axel.lin@ingics.com> wrote:
> Current code does not set gpio output value in ich6_gpio_direction_output(),
> fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/gpio/intel_ich6_gpio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/intel_ich6_gpio.c b/drivers/gpio/intel_ich6_gpio.c
> index b095d17..92c23ae 100644
> --- a/drivers/gpio/intel_ich6_gpio.c
> +++ b/drivers/gpio/intel_ich6_gpio.c
> @@ -251,6 +251,8 @@ static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset,
> struct ich6_bank_priv *bank = dev_get_priv(dev);
> u32 tmplong;
>
> + gpio_set_value(offset, value);
> +
> tmplong = inl(bank->io_sel);
> tmplong &= ~(1UL << offset);
> outl(bank->io_sel, tmplong);
> --
> 1.9.1
>
Acked-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] gpio: intel_ich6: Set correct gpio output value in ich6_gpio_direction_output()
2014-12-07 21:39 ` Simon Glass
@ 2014-12-11 3:22 ` Simon Glass
0 siblings, 0 replies; 3+ messages in thread
From: Simon Glass @ 2014-12-11 3:22 UTC (permalink / raw)
To: u-boot
On 7 December 2014 at 14:39, Simon Glass <sjg@chromium.org> wrote:
> On 6 December 2014 at 21:48, Axel Lin <axel.lin@ingics.com> wrote:
>> Current code does not set gpio output value in ich6_gpio_direction_output(),
>> fix it.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>> drivers/gpio/intel_ich6_gpio.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpio/intel_ich6_gpio.c b/drivers/gpio/intel_ich6_gpio.c
>> index b095d17..92c23ae 100644
>> --- a/drivers/gpio/intel_ich6_gpio.c
>> +++ b/drivers/gpio/intel_ich6_gpio.c
>> @@ -251,6 +251,8 @@ static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset,
>> struct ich6_bank_priv *bank = dev_get_priv(dev);
>> u32 tmplong;
>>
>> + gpio_set_value(offset, value);
>> +
>> tmplong = inl(bank->io_sel);
>> tmplong &= ~(1UL << offset);
>> outl(bank->io_sel, tmplong);
>> --
>> 1.9.1
>>
>
> Acked-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-x86 - thanks!
- Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-11 3:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-07 4:48 [U-Boot] [PATCH] gpio: intel_ich6: Set correct gpio output value in ich6_gpio_direction_output() Axel Lin
2014-12-07 21:39 ` Simon Glass
2014-12-11 3:22 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox