public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] sunxi: mmc: Properly setup mod-clk and clock sampling phases
Date: Mon, 08 Dec 2014 09:28:27 +0000	[thread overview]
Message-ID: <1418030907.11028.2.camel@hellion.org.uk> (raw)
In-Reply-To: <1417983799-13912-2-git-send-email-hdegoede@redhat.com>

On Sun, 2014-12-07 at 21:23 +0100, Hans de Goede wrote:
> The sunxi mmc controller has both an internal clock divider, as well as
> the divider in the mod0-clk for the mmc controller.
> 
> The internal divider cannot be used, as it conflicts with the setting of
> clock sampling phases which is done in the mod0-clk, so it must be set to
> 0 (divide by 1).
> 
> For some reason while the kernel has had this correct from day one, the
> u-boot sunxi mmc code has been using a fixed mod0-clk and setting its
> internal divider depending on the desired speed. This is something which
> we've inherited from the original Allwinner u-boot sources, but while this
> has been fixed in Allwinner's own u-boot code at least for the A23 and later
> upstream u-boot was still doing this wrong.
> 
> This commit fixes this, thereby also fixing mmc support not working reliable
> on the A23 (which seems more sensitive to this) and possible also fixes some
> other sunxi mmc issues.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Ian Campbell <ijc@hellion.org.uk>

  reply	other threads:[~2014-12-08  9:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-07 20:23 [U-Boot] [PATCH 1/2] sun6i: Update Colombus defconfig settings Hans de Goede
2014-12-07 20:23 ` [U-Boot] [PATCH 2/2] sunxi: mmc: Properly setup mod-clk and clock sampling phases Hans de Goede
2014-12-08  9:28   ` Ian Campbell [this message]
2014-12-08  9:26 ` [U-Boot] [PATCH 1/2] sun6i: Update Colombus defconfig settings Ian Campbell
2014-12-08  9:31   ` Ian Campbell
2014-12-08 10:59     ` Hans de Goede
2014-12-08 11:04       ` Ian Campbell
2014-12-09  9:29         ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418030907.11028.2.camel@hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox