public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] odroid-XU3: Add entry for DTS EHCI GPIO
Date: Tue, 09 Dec 2014 08:44:36 +0100	[thread overview]
Message-ID: <1418111076.32660.65.camel@collabora.co.uk> (raw)
In-Reply-To: <20141209131047.1e54b691@hwh-ubuntu>

Hey Hyungwon Hwang,

On Tue, 2014-12-09 at 13:10 +0900, Hyungwon Hwang wrote:
> Dear all,
> 
> On Mon, 08 Dec 2014 19:36:46 -0800
> Suriyan Ramasami <suriyan.r@gmail.com> wrote:

> > In odroid_xu3.h you might want to add the below as well (for LAN +
> > USB storage)
> > 
> > +/* Enable USB */
> > +#define CONFIG_CMD_USB
> > +#define CONFIG_USB_EHCI
> > +#define CONFIG_USB_EHCI_EXYNOS
> > +#define CONFIG_USB_STORAGE
> > +#define CONFIG_CMD_DHCP
> > +#define CONFIG_USB_HOST_ETHER
> > +#define CONFIG_USB_ETHER_SMSC95XX
> > 
> 
> Thanks for your reply. It works after above configs added.
> 
> It seems all configs which Suriyan specified are needed. Even though
> DHCP can be useless depending on the network situation. Sjoerd, How
> about add above configs for odroid_xu3.h?

I sent a seperate patch with the title "Exynos: Move down common USB
configuration", which adds the common configuration of USB
storage/network support + common usb devices into exynos5-common.h so it
can be shared among all exynos5 boards which i think is a better
solution then adding non-board specific configuration to the XU3 config

> Also, I think it is better to commit this patch separately with my
> patchset, because it took too long from when the first patch
> submitted, and I really want to make it merged with at least minimum
> functionalities.

That's fair enough. I don't mind either way. Thanks for testing!

-- 
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6170 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141209/6089c4d2/attachment.bin>

  reply	other threads:[~2014-12-09  7:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05 20:26 [U-Boot] [PATCH v2] odroid-XU3: Add entry for DTS EHCI GPIO Sjoerd Simons
2014-12-09  3:01 ` Hyungwon Hwang
2014-12-09  3:36   ` Suriyan Ramasami
2014-12-09  4:10     ` Hyungwon Hwang
2014-12-09  7:44       ` Sjoerd Simons [this message]
2014-12-09  4:25     ` Kevin Hilman
2014-12-22 12:22 ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418111076.32660.65.camel@collabora.co.uk \
    --to=sjoerd.simons@collabora.co.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox