From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ijc@hellion.org.uk>
Date: Thu, 18 Dec 2014 18:59:21 +0000
Subject: [U-Boot] [PATCH 02/14] sunxi: Add support for the rsb (Reduced
 Serial Bus)
In-Reply-To: <54917D61.8080204@redhat.com>
References: <1418761900-14035-1-git-send-email-hdegoede@redhat.com>
	<1418761900-14035-2-git-send-email-hdegoede@redhat.com>
	<CAGb2v66rfN0bsuPaOCQwRcx3C95H6rgM=K7hwjOYrbWSFYHO9A@mail.gmail.com>
	<54917D61.8080204@redhat.com>
Message-ID: <1418929161.26985.94.camel@hellion.org.uk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wed, 2014-12-17 at 13:56 +0100, Hans de Goede wrote:
> >> @@ -128,7 +128,8 @@
> >>   #define SUN6I_CPUCFG_BASE              0x01f01c00
> >>   #define SUNXI_R_UART_BASE              0x01f02800
> >>   #define SUNXI_R_PIO_BASE               0x01f02c00
> >> -#define SUNXI_P2WI_BASE                        0x01f03400
> >> +#define SUNXI_P2WI_BASE                        0x01f03400      /* on sun6i */
> >> +#define SUNXI_RSB_BASE                 0x01f03400      /* on sun8i */
> >
> > Maybe we just use SUN6I_ SUN8I_ prefixes?
> > The base address will be different on sun9i.

Did you miss this suggestions from Chen-Yu? Seems like a good one.

I don't have any other comments.

Ian.