From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Howard Date: Sat, 20 Dec 2014 10:54:09 +1100 Subject: [U-Boot] [PATCH RFT 2/2] davinci: Do not duplicate setting of gd In-Reply-To: <1419026005-5549-2-git-send-email-trini@ti.com> References: <1419026005-5549-1-git-send-email-trini@ti.com> <1419026005-5549-2-git-send-email-trini@ti.com> Message-ID: <1419033249.3987.1.camel@localhost.localdomain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, 2014-12-19 at 16:53 -0500, Tom Rini wrote: > In f0c3a6c we stopped setting gd in board_init_f, but later had to > revert to due problems on certain platforms. As davinci does not look > to have these problems, we can drop the setting here and rely upon > crt0.S to do it. > > Cc: Peter Howard > Signed-off-by: Tom Rini > > --- > Peter, I don't have my davinci board hooked up but since you were doing > some changes recently is there a chance you can test this easily? I can test on Monday - I only have access to my LCDK on the weekend, and I have to get round to try the convoluted setup process for flashing u-boot on it :-) > Thanks! > --- > arch/arm/cpu/arm926ejs/davinci/spl.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/cpu/arm926ejs/davinci/spl.c b/arch/arm/cpu/arm926ejs/davinci/spl.c > index 59b304e..7b14420 100644 > --- a/arch/arm/cpu/arm926ejs/davinci/spl.c > +++ b/arch/arm/cpu/arm926ejs/davinci/spl.c > @@ -51,7 +51,6 @@ void board_init_f(ulong dummy) > memset(__bss_start, 0, __bss_end - __bss_start); > > /* Finally, setup gd and move to the next step. */ > - gd = &gdata; > board_init_r(NULL, 0); > } >