From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: sunxi: Fix misuse of gpio_direction_input()
Date: Mon, 22 Dec 2014 12:59:00 +0000 [thread overview]
Message-ID: <1419253140.26985.179.camel@hellion.org.uk> (raw)
In-Reply-To: <CAPnjgZ2g5f=7cjDA3rt7Wp17soCQVNCWbayh-dZZbuB0VVN8=A@mail.gmail.com>
On Sun, 2014-12-21 at 11:53 -0700, Simon Glass wrote:
> On 19 December 2014 at 20:41, Axel Lin <axel.lin@ingics.com> wrote:
> > It does not make sense to make gpio_direction_input() return the gpio input
> > status. The return value of gpio_direction_input() is inconsistent if
> > CONFIG_DM_GPIO is defined.
> > And we don't need to call gpio_direction_input() int sunxi_mmc_getcd().
> > Just init the gpio once in mmc_resource_init() is enough.
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > ---
> > Only compile tested, so please test this patch.
> > Thanks.
> > drivers/gpio/sunxi_gpio.c | 2 +-
> > drivers/mmc/sunxi_mmc.c | 7 +++++--
> > 2 files changed, 6 insertions(+), 3 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Thanks, I booted it on my cubietruck and I could still see the mmc, so
I've queued to u-boot-sunxi#next.
I don't think we need to rush this into v2015.01, but do shout if you
think we do.
Ian.
next prev parent reply other threads:[~2014-12-22 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 3:41 [U-Boot] [PATCH] mmc: sunxi: Fix misuse of gpio_direction_input() Axel Lin
2014-12-21 18:53 ` Simon Glass
2014-12-22 12:59 ` Ian Campbell [this message]
2014-12-22 14:08 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419253140.26985.179.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox