From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ijc@hellion.org.uk>
Date: Sun, 28 Dec 2014 09:19:02 +0000
Subject: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to
	board_init_f()
In-Reply-To: <1419361499-31967-3-git-send-email-sjg@chromium.org>
References: <1419361499-31967-1-git-send-email-sjg@chromium.org>
	<1419361499-31967-3-git-send-email-sjg@chromium.org>
Message-ID: <1419758342.13595.28.camel@hellion.org.uk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, 2014-12-23 at 12:04 -0700, Simon Glass wrote:

> +void board_init_f(ulong dummy)
> +{
[...]
> +	/* Clear the BSS. */
> +	memset(__bss_start, 0, __bss_end - __bss_start);
> +
> +	board_init_r(NULL, 0);

The previous (__weak) version of board_init_f also sets gd, which you've
also removed from s_init here and not added back anywhere (indeed, this
is the point...). But where is gd initialised now?

The patch generally looks good, two quick questions: has it been tested
in both FEL and regular mode, and has it been tested with a "legacy" as
well as a driver model system? (I might be able to find time in a day or
two to answer these myself, but for now I'll just ask).

Ian.