From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Date: Thu, 08 Jan 2015 08:33:58 +0000 Subject: [U-Boot] [PATCH 2/3] sunxi: video: Add support for Hitachi tx18d42vm LCD panels In-Reply-To: <54AD9136.4090600@redhat.com> References: <1420401940-15136-1-git-send-email-hdegoede@redhat.com> <1420401940-15136-2-git-send-email-hdegoede@redhat.com> <1420657167.11796.41.camel@hellion.org.uk> <54AD9136.4090600@redhat.com> Message-ID: <1420706038.11796.47.camel@hellion.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 2015-01-07 at 21:04 +0100, Hans de Goede wrote: > Hi, > > On 07-01-15 19:59, Ian Campbell wrote: > > On Sun, 2015-01-04 at 21:05 +0100, Hans de Goede wrote: > >> Hitachi tx18d42vm LCD panels have an onboard controller which needs some > >> initialization via spi for the panel to become functional as a regular LVDS > >> panel. > > > > This doesn't sound terribly sunxi specific, shouldn't > > sunxi_lcd_panel_hitachi_tx18d42vm_init be generic but making use of some > > sort of arch-provided interface for actually talking SPI to the device > > (which may or may not use the generic SPI infra, as your code comment > > talked about)? > > You're right it is not sunxi specific, but for now sunxi is the only user > (I've checked) so this seemed simplest, with the idea that it is always > much easier to make something properly generic when there is more then one > user. I think we are more likely to simply end up with N versions of this code because no one notices that it already exists under some other name. If Anatolij is OK with it then I have no objections. > > I guess I should have put something about this in the commit message :) > > Regards, > > Hans >