From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] sunxi: video: Add lvds support
Date: Thu, 08 Jan 2015 08:36:00 +0000 [thread overview]
Message-ID: <1420706160.11796.49.camel@hellion.org.uk> (raw)
In-Reply-To: <54AD8FFE.3000905@redhat.com>
On Wed, 2015-01-07 at 20:58 +0100, Hans de Goede wrote:
> Hi,
>
> On 07-01-15 19:56, Ian Campbell wrote:
> > On Sun, 2015-01-04 at 21:05 +0100, Hans de Goede wrote:
> >> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
> >> index 8782394..fdb18a4 100644
> >> --- a/board/sunxi/Kconfig
> >> +++ b/board/sunxi/Kconfig
> >> @@ -345,6 +345,20 @@ config VIDEO_LCD_BL_PWM
> >> Set the backlight pwm pin for the LCD panel. This takes a string in the
> >> format understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
> >>
> >> +choice
> >> + prompt "LCD panel support"
> >> + depends on VIDEO
> >> + ---help---
> >> + Select which type of LCD panel to support.
> >> +
> >> +config VIDEO_LCD_PANEL_PARALLEL
> >> + bool "Generic parallel interface LCD panel"
> >
> > I don't see any use of this choice, I suppose it is the #else case?
>
> Right, it is the else case in the actual code (for now).
>
> > Are there other (third) options for LCDs?
>
> Yes, see the second patch in this series,
I've replied to the second patch again because it doesn't seem right to
put the specific choice of panel under the class of panel choice label.
> and Sairhei has a tablet which
> needs something similar (but different) to the second patch.
I can't find a reference for this, but I suppose it might imply that the
choice of panel should be a Kconfig choice too, just not the same one as
the general class of panel Kconfig choice (IYSWIM).
Ian.
prev parent reply other threads:[~2015-01-08 8:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 20:05 [U-Boot] [PATCH 1/3] sunxi: video: Add lvds support Hans de Goede
2015-01-04 20:05 ` [U-Boot] [PATCH 2/3] sunxi: video: Add support for Hitachi tx18d42vm LCD panels Hans de Goede
2015-01-07 18:59 ` Ian Campbell
2015-01-07 20:04 ` Hans de Goede
2015-01-08 8:33 ` Ian Campbell
2015-01-08 8:32 ` Ian Campbell
2015-01-08 8:39 ` Hans de Goede
2015-01-08 9:04 ` Ian Campbell
2015-01-04 20:05 ` [U-Boot] [PATCH 3/3] sunxi: Add new Chuwi V7 CW0825 board / defconfig Hans de Goede
2015-01-07 19:00 ` Ian Campbell
2015-01-07 18:56 ` [U-Boot] [PATCH 1/3] sunxi: video: Add lvds support Ian Campbell
2015-01-07 19:58 ` Hans de Goede
2015-01-08 8:36 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420706160.11796.49.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox