[U-Boot] [PATCH v2 0/2] sunxi: video: Add lvds support

[Ian Campbell <ijc@hellion.org.uk>]

On Thu, 2015-01-08 at 20:49 +0100, Hans de Goede wrote:
> Hi Ian, Anatolij,
> 
> Here is v2 of the lvds support for sunxi-video. I've reworked how to Kconfig
> bits are handled as requested by Ian.
> 
> Anatolij, the second patch in this sets adds support for initializing the
> lcd controller found on hitachi tx18d42vm lcd panels, this lvds lcd controller
> needs some poking via a separate spi bus before the panel will do anything.
> 
> This code is not really sunxi specific, but since sunxi is the only (known)
> user of such a lcd controller I've chosen to do this in a sunxi specific file
> for now, with the idea that making the code generic is more easy when we
> actually have a second user, and thus a better idea of what is needed for a
> generic implementation. Can we get your ack for this solution? Or let me know
> if you want me todo something generic right away and then I'll rework the
> patch.

Anatolij has acked it, so I don't object.

Acked-by: Ian Campbell <ijc@hellion.org.uk>

Do you think it might be worth doing:

#if definged(CONFIG_VIDEO_LCD_IF_PARALLEL)
...
#elif defined(CONFIG_VIDEO_LCD_IF_LVDS)
...
#else
#error unknown LCD_IF
#endif

instead of the independnent #ifdef's, so anyone adding a third option
gets a warning to think about at each site? (Just a suggestion, not to
block the patches if you disagree).

Ian.