From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: axp221: correct ALDO2 description for sun6i
Date: Sun, 11 Jan 2015 09:38:14 +0000 [thread overview]
Message-ID: <1420969094.11796.123.camel@hellion.org.uk> (raw)
In-Reply-To: <1420251444-19117-1-git-send-email-wens@csie.org>
On Sat, 2015-01-03 at 10:17 +0800, Chen-Yu Tsai wrote:
> ALDO2 is used to power LPDDR2 SDRAM on both the reference design and the
> Hummingbird A31, when this type of RAM is present.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
I think this one needs Hans' opinion more than mine, but looks OK to me
with one small comment:
> + disable aldo2. On sun6i (A31) boards this is typically used for LPDDR2
> + SDRAM, and should be set to 1.8V if present. On sun8i (A23) this is
> + typically connected to VDD-DLL and must be set to 2.5V.
It took me a while to work out why "set to 1.8V if present" wasn't
reflected in the default (which you changed to zero in this patch), I
think there is an implied "which is almost never" on the end? But that
wouldn't be in keeping with the style of things. How about:
[...] On sun6i (A31) boards this is typically unused and should
be disabled, if it is used for LPDDR2 it should be set to 1.8V.
[...]
?
>
> config AXP221_ALDO3_VOLT
> int "axp221 aldo3 voltage"
next prev parent reply other threads:[~2015-01-11 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 2:17 [U-Boot] [PATCH] sunxi: axp221: correct ALDO2 description for sun6i Chen-Yu Tsai
2015-01-11 9:38 ` Ian Campbell [this message]
2015-01-11 9:41 ` Chen-Yu Tsai
2015-01-11 9:51 ` Ian Campbell
2015-01-13 12:00 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420969094.11796.123.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox