public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] mmc: Skip changing bus width for MMC cards earlier than version 4.0
Date: Tue, 13 Jan 2015 10:22:57 +0000	[thread overview]
Message-ID: <1421144577.2694.11.camel@synopsys.com> (raw)
In-Reply-To: <1419524545-18136-3-git-send-email-andrew_gabbasov@mentor.com>

Hi Pantelis,

On Thu, 2014-12-25 at 10:22 -0600, Andrew Gabbasov wrote:
> Wider bus widths (larger than default 1 bit) appeared in MMC standard
> version 4.0. So, for MMC cards of any earlier version trying to change
> the bus width (including ext_csd comparison) does not make any sense.
> It may work incorrectly and at least cause unnecessary timeouts.
> So, just skip the entire bus width related activity for earlier versions.
> 
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> Tested-by: Alexey Brodkin <abrodkin@synopsys.com>

This change fixes regression introduced in
https://patchwork.ozlabs.org/patch/416442/ for MMC cards.

Please consider applying if you don't have any objections.

Regards,
Alexey

  reply	other threads:[~2015-01-13 10:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-25 16:22 [U-Boot] [PATCH 0/2] Fix some corner cases in bus width setting Andrew Gabbasov
2014-12-25 16:22 ` [U-Boot] [PATCH 1/2] mmc: Avoid redundant switching to 1-bit bus width for MMC cards Andrew Gabbasov
2015-01-19 14:42   ` Pantelis Antoniou
2014-12-25 16:22 ` [U-Boot] [PATCH 2/2] mmc: Skip changing bus width for MMC cards earlier than version 4.0 Andrew Gabbasov
2015-01-13 10:22   ` Alexey Brodkin [this message]
2015-01-19 14:45   ` Pantelis Antoniou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421144577.2694.11.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox