From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ijc@hellion.org.uk>
Date: Tue, 13 Jan 2015 19:59:21 +0000
Subject: [U-Boot] [PATCH 17/17] sunxi: Hookup OTG USB controller support
In-Reply-To: <1421004895-10896-18-git-send-email-hdegoede@redhat.com>
References: <1421004895-10896-1-git-send-email-hdegoede@redhat.com>
	<1421004895-10896-18-git-send-email-hdegoede@redhat.com>
Message-ID: <1421179161.11796.163.camel@hellion.org.uk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sun, 2015-01-11 at 20:34 +0100, Hans de Goede wrote:
> Hookup OTG USB controller support and enable the otg controller + USB-keyb
> on various tablets.
> 
> This allows tablet owners to interact with u-boot without needing to solder
> a serial console onto their tablet PCB.

Looks good, except I can't for the life of me find where
CONFIG_MUSB_GADGET is ever set for a sunxi platform.

I suspect it's just there in preparation for some future gadget mode
work (what we care about here is host mode), is that right?

If so: Acked-by: Ian Campbell <ijc@hellion.org.uk>

> +#if defined(CONFIG_MUSB_HOST) || defined(CONFIG_MUSB_GADGET)

Not just #ifdef CONFIG_USB_MUSB_SUNXI? (Ack either way)

Ian.