From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Date: Wed, 14 Jan 2015 06:23:55 +0000
Subject: [U-Boot] [PATCH 2/2] config_cmd_default.h: wrap each definition
 in "ifndef"
In-Reply-To: <20150114131254.7103.AA925319@jp.panasonic.com>
References: <1420291209-20249-3-git-send-email-abrodkin@synopsys.com>
	<1420838479.3108.5.camel@synopsys.com>
	<20150114131254.7103.AA925319@jp.panasonic.com>
Message-ID: <1421216635.2954.2.camel@synopsys.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Masahiro-san,

On Wed, 2015-01-14 at 13:12 +0900, Masahiro Yamada wrote:
> On Fri, 9 Jan 2015 21:21:20 +0000
> Alexey Brodkin <Alexey.Brodkin@synopsys.com> wrote:
> I think this change is harmless, but
> 
> #define CONFIG_CMD_BDI   1
> 
> is simpler than
> 
> #ifndef CONFIG_CMD_BDI
> #define CONFIG_CMD_BDI
> #endif
> 
> 
> Maybe?

I don't think so :)

Please look at Wolfgang's comment here
http://lists.denx.de/pipermail/u-boot/2014-February/172494.html

--->8---
Please do not define values for logical variables [please check
everywhere].
--->8---

-Alexey