From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: Only compile board.o for CONFIG_SPL_BUILD
Date: Wed, 21 Jan 2015 08:58:30 +0000 [thread overview]
Message-ID: <1421830710.13341.98.camel@hellion.org.uk> (raw)
In-Reply-To: <20150120214052.GX10826@bill-the-cat>
On Tue, 2015-01-20 at 16:40 -0500, Tom Rini wrote:
In general the change looks good, thanks.
> -#if !defined CONFIG_SPL_BUILD && (defined CONFIG_MACH_SUN7I || \
> - defined CONFIG_MACH_SUN6I || defined CONFIG_MACH_SUN8I)
> - /* Enable SMP mode for CPU0, by setting bit 6 of Auxiliary Ctl reg */
> - asm volatile(
> - "mrc p15, 0, r0, c1, c0, 1\n"
> - "orr r0, r0, #1 << 6\n"
> - "mcr p15, 0, r0, c1, c0, 1\n");
> -#endif
Hans has an in flight patch which moves this elsewhere. But what's
confusing me is how it ever worked at all if this wasn't even being
compiled in. ACTLR.SMP is pretty critical to correct operation of the
SoC (cache coherency etc), at least once secondary processors are up...
Ian.
next prev parent reply other threads:[~2015-01-21 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 21:40 [U-Boot] [PATCH] sunxi: Only compile board.o for CONFIG_SPL_BUILD Tom Rini
2015-01-21 8:58 ` Ian Campbell [this message]
2015-01-21 13:18 ` Hans de Goede
2015-01-21 14:13 ` Tom Rini
2015-01-21 16:17 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421830710.13341.98.camel@hellion.org.uk \
--to=ijc+uboot@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox