public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/2] sunxi: video: Make pwm polarity configurable
@ 2015-01-22 20:24 Hans de Goede
  2015-01-22 20:24 ` [U-Boot] [PATCH 2/2] sunxi: Add Hyundai A7HD support Hans de Goede
  2015-01-23  9:53 ` [U-Boot] [PATCH 1/2] sunxi: video: Make pwm polarity configurable Ian Campbell
  0 siblings, 2 replies; 4+ messages in thread
From: Hans de Goede @ 2015-01-22 20:24 UTC (permalink / raw)
  To: u-boot

It turns out that there are some panels where the pwm input is not active low,
so make it configurable.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 board/sunxi/Kconfig           |  7 +++++++
 drivers/video/sunxi_display.c | 17 +++++++++++------
 2 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
index 0e3c207..738b55e 100644
--- a/board/sunxi/Kconfig
+++ b/board/sunxi/Kconfig
@@ -319,6 +319,13 @@ config VIDEO_LCD_BL_PWM
 	Set the backlight pwm pin for the LCD panel. This takes a string in the
 	format understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
 
+config VIDEO_LCD_BL_PWM_ACTIVE_LOW
+	bool "LCD panel backlight pwm is inverted"
+	depends on VIDEO
+	default y
+	---help---
+	Set this if the backlight pwm output is active low.
+
 
 # Note only one of these may be selected at a time! But hidden choices are
 # not supported by Kconfig
diff --git a/drivers/video/sunxi_display.c b/drivers/video/sunxi_display.c
index 5077111..af728b5 100644
--- a/drivers/video/sunxi_display.c
+++ b/drivers/video/sunxi_display.c
@@ -23,6 +23,14 @@
 #include "hitachi_tx18d42vm_lcd.h"
 #include "ssd2828.h"
 
+#ifdef CONFIG_VIDEO_LCD_BL_PWM_ACTIVE_LOW
+#define PWM_ON 0
+#define PWM_OFF 1
+#else
+#define PWM_ON 1
+#define PWM_OFF 0
+#endif
+
 DECLARE_GLOBAL_DATA_PTR;
 
 enum sunxi_monitor {
@@ -598,8 +606,7 @@ static void sunxi_lcdc_panel_enable(void)
 	pin = sunxi_name_to_gpio(CONFIG_VIDEO_LCD_BL_PWM);
 	if (pin != -1) {
 		gpio_request(pin, "lcd_backlight_pwm");
-		/* backlight pwm is inverted, set to 1 to disable backlight */
-		gpio_direction_output(pin, 1);
+		gpio_direction_output(pin, PWM_OFF);
 	}
 
 	/* Give the backlight some time to turn off and power up the panel. */
@@ -626,10 +633,8 @@ static void sunxi_lcdc_backlight_enable(void)
 		gpio_direction_output(pin, 1);
 
 	pin = sunxi_name_to_gpio(CONFIG_VIDEO_LCD_BL_PWM);
-	if (pin != -1) {
-		/* backlight pwm is inverted, set to 0 to enable backlight */
-		gpio_direction_output(pin, 0);
-	}
+	if (pin != -1)
+		gpio_direction_output(pin, PWM_ON);
 }
 
 static int sunxi_lcdc_get_clk_delay(const struct ctfb_res_modes *mode)
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 2/2] sunxi: Add Hyundai A7HD support
  2015-01-22 20:24 [U-Boot] [PATCH 1/2] sunxi: video: Make pwm polarity configurable Hans de Goede
@ 2015-01-22 20:24 ` Hans de Goede
  2015-01-23  9:54   ` Ian Campbell
  2015-01-23  9:53 ` [U-Boot] [PATCH 1/2] sunxi: video: Make pwm polarity configurable Ian Campbell
  1 sibling, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2015-01-22 20:24 UTC (permalink / raw)
  To: u-boot

The Hyundai A7HD is a 7" 16:9 A10 powered tablet featuring 1G RAM, 8G
nand, 1024x600 IPS screen, a mini hdmi port, mini usb receptacle and a
headphones port for details see: http://linux-sunxi.org/Hyundai_A7HD

Cc: Mark Janssen <maniac@maniac.nl>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 board/sunxi/MAINTAINERS        |  1 +
 configs/Hyundai_A7HD_defconfig | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+)
 create mode 100644 configs/Hyundai_A7HD_defconfig

diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS
index b540bd3..743e7f5 100644
--- a/board/sunxi/MAINTAINERS
+++ b/board/sunxi/MAINTAINERS
@@ -7,6 +7,7 @@ F:	configs/A10-OLinuXino-Lime_defconfig
 F:	configs/ba10_tv_box_defconfig
 F:	configs/Chuwi_V7_CW0825_defconfig
 F:	configs/Cubieboard_defconfig
+F:	configs/Hyundai_A7HD_defconfig
 F:	configs/Mele_A1000_defconfig
 F:	configs/Mele_M3_defconfig
 F:	configs/Mini-X_defconfig
diff --git a/configs/Hyundai_A7HD_defconfig b/configs/Hyundai_A7HD_defconfig
new file mode 100644
index 0000000..60eb03e
--- /dev/null
+++ b/configs/Hyundai_A7HD_defconfig
@@ -0,0 +1,22 @@
+# The Hyundai A7HD is a 7" 16:9 A10 powered tablet featuring 1G RAM, 8G
+# nand, 1024x600 IPS screen, a mini hdmi port, mini usb receptacle and a
+# headphones port for details see: http://linux-sunxi.org/Hyundai_A7HD
+CONFIG_SPL=y
+CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER"
+CONFIG_FDTFILE="sun4i-a10-hyundai-a7hd.dtb"
+CONFIG_USB_MUSB_SUNXI=y
+CONFIG_USB0_VBUS_PIN="PB09"
+CONFIG_USB2_VBUS_PIN=""
+CONFIG_VIDEO_LCD_MODE="x:1024,y:600,depth:18,pclk_khz:51000,le:45,ri:274,up:22,lo:12,hs:1,vs:1,sync:3,vmode:0"
+CONFIG_VIDEO_LCD_DCLK_PHASE=1
+CONFIG_VIDEO_LCD_POWER="PH2"
+CONFIG_VIDEO_LCD_BL_EN="PH9"
+CONFIG_VIDEO_LCD_BL_PWM="PB2"
+CONFIG_VIDEO_LCD_BL_PWM_ACTIVE_LOW=n
+CONFIG_VIDEO_LCD_PANEL_LVDS=y
++S:CONFIG_ARM=y
++S:CONFIG_ARCH_SUNXI=y
++S:CONFIG_MACH_SUN4I=y
++S:CONFIG_DRAM_CLK=360
++S:CONFIG_DRAM_ZQ=123
++S:CONFIG_DRAM_EMR1=4
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 1/2] sunxi: video: Make pwm polarity configurable
  2015-01-22 20:24 [U-Boot] [PATCH 1/2] sunxi: video: Make pwm polarity configurable Hans de Goede
  2015-01-22 20:24 ` [U-Boot] [PATCH 2/2] sunxi: Add Hyundai A7HD support Hans de Goede
@ 2015-01-23  9:53 ` Ian Campbell
  1 sibling, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2015-01-23  9:53 UTC (permalink / raw)
  To: u-boot

On Thu, 2015-01-22 at 21:24 +0100, Hans de Goede wrote:
> It turns out that there are some panels where the pwm input is not active low,
> so make it configurable.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Ian Campbell <ijc@hellion.org.uk>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 2/2] sunxi: Add Hyundai A7HD support
  2015-01-22 20:24 ` [U-Boot] [PATCH 2/2] sunxi: Add Hyundai A7HD support Hans de Goede
@ 2015-01-23  9:54   ` Ian Campbell
  0 siblings, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2015-01-23  9:54 UTC (permalink / raw)
  To: u-boot

On Thu, 2015-01-22 at 21:24 +0100, Hans de Goede wrote:
> The Hyundai A7HD is a 7" 16:9 A10 powered tablet featuring 1G RAM, 8G
> nand, 1024x600 IPS screen, a mini hdmi port, mini usb receptacle and a
> headphones port for details see: http://linux-sunxi.org/Hyundai_A7HD
> 
> Cc: Mark Janssen <maniac@maniac.nl>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Ian Campbell <ijc@hellion.org.uk>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-01-23  9:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-22 20:24 [U-Boot] [PATCH 1/2] sunxi: video: Make pwm polarity configurable Hans de Goede
2015-01-22 20:24 ` [U-Boot] [PATCH 2/2] sunxi: Add Hyundai A7HD support Hans de Goede
2015-01-23  9:54   ` Ian Campbell
2015-01-23  9:53 ` [U-Boot] [PATCH 1/2] sunxi: video: Make pwm polarity configurable Ian Campbell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox