From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] sunxi: Add a GMAC Transmit Clock Delay Chain Kconfig option
Date: Wed, 28 Jan 2015 09:10:22 +0000 [thread overview]
Message-ID: <1422436222.29309.27.camel@hellion.org.uk> (raw)
In-Reply-To: <1422196540-18093-2-git-send-email-hdegoede@redhat.com>
On Sun, 2015-01-25 at 15:35 +0100, Hans de Goede wrote:
> And use this to set the GMAC Transmit Clock Delay Chain value on Banana
> boards, rather then keying of CONFIG_TARGET_FOO.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Ian Campbell <ijc@hellion.org.uk>
Although:
> @@ -24,20 +24,13 @@ int sunxi_gmac_initialize(bd_t *bis)
> #ifdef CONFIG_RGMII
> setbits_le32(&ccm->gmac_clk_cfg, CCM_GMAC_CTRL_TX_CLK_SRC_INT_RGMII |
> CCM_GMAC_CTRL_GPIT_RGMII);
> + setbits_le32(&ccm->gmac_clk_cfg,
> + CCM_GMAC_CTRL_TX_CLK_DELAY(CONFIG_GMAC_TX_DELAY));
You could have added
| CCM_GMAC_CTRL_TX_CLK_DELAY(CONFIG_GMAC_TX_DELAY)
to the existing setbits I think. Ack to that change too if you prefer
it.
Ian.
next prev parent reply other threads:[~2015-01-28 9:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-25 14:35 [U-Boot] [PATCH 1/4] sunxi: Convert sun5i boards to use auto dram configuration Hans de Goede
2015-01-25 14:35 ` [U-Boot] [PATCH 2/4] sunxi: Add a GMAC Transmit Clock Delay Chain Kconfig option Hans de Goede
2015-01-28 9:10 ` Ian Campbell [this message]
2015-01-25 14:35 ` [U-Boot] [PATCH 3/4] sunxi: Remove CONFIG_TARGET_FOO for sun5i and sun7i boards Hans de Goede
2015-01-28 9:10 ` Ian Campbell
2015-01-25 14:35 ` [U-Boot] [PATCH 4/4] sunxi: video: Force h/vsync active high when using ext. vga dac Hans de Goede
2015-01-28 9:13 ` Ian Campbell
2015-01-28 9:37 ` Hans de Goede
2015-01-28 9:08 ` [U-Boot] [PATCH 1/4] sunxi: Convert sun5i boards to use auto dram configuration Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422436222.29309.27.camel@hellion.org.uk \
--to=ijc+uboot@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox