From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ijc+uboot@hellion.org.uk>
Date: Wed, 28 Jan 2015 09:10:22 +0000
Subject: [U-Boot] [PATCH 2/4] sunxi: Add a GMAC Transmit Clock Delay
 Chain Kconfig option
In-Reply-To: <1422196540-18093-2-git-send-email-hdegoede@redhat.com>
References: <1422196540-18093-1-git-send-email-hdegoede@redhat.com>
	<1422196540-18093-2-git-send-email-hdegoede@redhat.com>
Message-ID: <1422436222.29309.27.camel@hellion.org.uk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sun, 2015-01-25 at 15:35 +0100, Hans de Goede wrote:
> And use this to set the GMAC Transmit Clock Delay Chain value on Banana
> boards, rather then keying of CONFIG_TARGET_FOO.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Ian Campbell <ijc@hellion.org.uk>

Although:
> @@ -24,20 +24,13 @@ int sunxi_gmac_initialize(bd_t *bis)
>  #ifdef CONFIG_RGMII
>  	setbits_le32(&ccm->gmac_clk_cfg, CCM_GMAC_CTRL_TX_CLK_SRC_INT_RGMII |
>  		CCM_GMAC_CTRL_GPIT_RGMII);
> +	setbits_le32(&ccm->gmac_clk_cfg,
> +		     CCM_GMAC_CTRL_TX_CLK_DELAY(CONFIG_GMAC_TX_DELAY));

You could have added
	| CCM_GMAC_CTRL_TX_CLK_DELAY(CONFIG_GMAC_TX_DELAY)
to the existing setbits I think. Ack to that change too if you prefer
it.

Ian.