public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] sunxi: rsb: Add sun9i (A80 support)
Date: Wed, 28 Jan 2015 09:39:50 +0000	[thread overview]
Message-ID: <1422437990.29309.42.camel@hellion.org.uk> (raw)
In-Reply-To: <54C8AB20.6000909@redhat.com>

On Wed, 2015-01-28 at 10:25 +0100, Hans de Goede wrote:
> Hi,
> 
> On 28-01-15 10:18, Ian Campbell wrote:
> > On Tue, 2015-01-27 at 11:27 +0100, Hans de Goede wrote:
> >> Add support for the A80 to the rsb code.
> >>
> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >
> >> @@ -129,6 +133,7 @@ enum sunxi_gpio_number {
> >>   #define SUNXI_GPI(_nr)	(SUNXI_GPIO_I_START + (_nr))
> >>   #define SUNXI_GPL(_nr)	(SUNXI_GPIO_L_START + (_nr))
> >>   #define SUNXI_GPM(_nr)	(SUNXI_GPIO_M_START + (_nr))
> >> +#define SUNXI_GPN(_nr)	(SUNXI_GPIO_L_START + (_nr))
> >                    ^ N vs             ^ L
> >
> > Is this correct or a cut-n-paste-o?
> 
> That is a cut-n-paste-o should be N_START obviously,
> will do a v2.

Thought so ;-) With the obvious s/L/N/ change you can immediately add:

Acked-by: Ian Campbell <ijc@hellion.org.uk>

> I guess the rsb did work because allwinner's boot0 already sets
> up the right muxing.

Likely.

Ian.

      reply	other threads:[~2015-01-28  9:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 10:27 [U-Boot] [PATCH 1/2] sunxi: rsb: Add sun9i (A80 support) Hans de Goede
2015-01-27 10:27 ` [U-Boot] [PATCH 2/2] sunxi: rsb: Move rsb_set_device_mode() call to rsb_init() Hans de Goede
2015-01-28  9:19   ` Ian Campbell
2015-01-28  9:18 ` [U-Boot] [PATCH 1/2] sunxi: rsb: Add sun9i (A80 support) Ian Campbell
2015-01-28  9:25   ` Hans de Goede
2015-01-28  9:39     ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422437990.29309.42.camel@hellion.org.uk \
    --to=ijc+uboot@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox