From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] sunxi: video: Force h/vsync active high when using ext. vga dac on some boards
Date: Wed, 28 Jan 2015 15:33:19 +0000 [thread overview]
Message-ID: <1422459199.5187.23.camel@hellion.org.uk> (raw)
In-Reply-To: <54C8F552.2010204@redhat.com>
On Wed, 2015-01-28 at 15:42 +0100, Hans de Goede wrote:
> > Although I might have been tempted to adjust mode->sync in the caller or
> > the place which populates it in the first place, just due to a general
> > dislike of boolean params to functions (which are opaque at the caller)
> > and to keep mode in sync with reality (if that matters).
>
> I had the same idea, but mode can point to the global fixed mode list, so
> it is: "const struct ctfb_res_modes *mode" and we cannot change what a const
> pointer points too.
Ah, then no, that won't work will it ;-).
Ian.
prev parent reply other threads:[~2015-01-28 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 10:47 [U-Boot] [PATCH v2] sunxi: video: Force h/vsync active high when using ext. vga dac on some boards Hans de Goede
2015-01-28 12:05 ` Ian Campbell
2015-01-28 14:42 ` Hans de Goede
2015-01-28 15:33 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422459199.5187.23.camel@hellion.org.uk \
--to=ijc+uboot@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox