From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Date: Wed, 28 Jan 2015 15:33:19 +0000 Subject: [U-Boot] [PATCH v2] sunxi: video: Force h/vsync active high when using ext. vga dac on some boards In-Reply-To: <54C8F552.2010204@redhat.com> References: <1422442041-21957-1-git-send-email-hdegoede@redhat.com> <1422446756.14124.9.camel@hellion.org.uk> <54C8F552.2010204@redhat.com> Message-ID: <1422459199.5187.23.camel@hellion.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 2015-01-28 at 15:42 +0100, Hans de Goede wrote: > > Although I might have been tempted to adjust mode->sync in the caller or > > the place which populates it in the first place, just due to a general > > dislike of boolean params to functions (which are opaque at the caller) > > and to keep mode in sync with reality (if that matters). > > I had the same idea, but mode can point to the global fixed mode list, so > it is: "const struct ctfb_res_modes *mode" and we cannot change what a const > pointer points too. Ah, then no, that won't work will it ;-). Ian.