* [U-Boot] [PATCH] gpio: omap: Pass correct argument to _get_gpio_direction()
@ 2015-01-31 14:23 Axel Lin
2015-02-03 0:55 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2015-01-31 14:23 UTC (permalink / raw)
To: u-boot
Pass bank rather than bank->base to _get_gpio_direction().
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/omap_gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/omap_gpio.c b/drivers/gpio/omap_gpio.c
index f3a7ccb..19fc451 100644
--- a/drivers/gpio/omap_gpio.c
+++ b/drivers/gpio/omap_gpio.c
@@ -291,7 +291,7 @@ static int omap_gpio_get_function(struct udevice *dev, unsigned offset)
struct gpio_bank *bank = dev_get_priv(dev);
/* GPIOF_FUNC is not implemented yet */
- if (_get_gpio_direction(bank->base, offset) == OMAP_GPIO_DIR_OUT)
+ if (_get_gpio_direction(bank, offset) == OMAP_GPIO_DIR_OUT)
return GPIOF_OUTPUT;
else
return GPIOF_INPUT;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] gpio: omap: Pass correct argument to _get_gpio_direction()
2015-01-31 14:23 [U-Boot] [PATCH] gpio: omap: Pass correct argument to _get_gpio_direction() Axel Lin
@ 2015-02-03 0:55 ` Simon Glass
2015-02-06 21:47 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Simon Glass @ 2015-02-03 0:55 UTC (permalink / raw)
To: u-boot
HI Axel,
On 31 January 2015 at 07:23, Axel Lin <axel.lin@ingics.com> wrote:
> Pass bank rather than bank->base to _get_gpio_direction().
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/gpio/omap_gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/omap_gpio.c b/drivers/gpio/omap_gpio.c
> index f3a7ccb..19fc451 100644
> --- a/drivers/gpio/omap_gpio.c
> +++ b/drivers/gpio/omap_gpio.c
> @@ -291,7 +291,7 @@ static int omap_gpio_get_function(struct udevice *dev, unsigned offset)
> struct gpio_bank *bank = dev_get_priv(dev);
>
> /* GPIOF_FUNC is not implemented yet */
> - if (_get_gpio_direction(bank->base, offset) == OMAP_GPIO_DIR_OUT)
> + if (_get_gpio_direction(bank, offset) == OMAP_GPIO_DIR_OUT)
> return GPIOF_OUTPUT;
> else
> return GPIOF_INPUT;
Ah yes another reason why we need a struct rather than void * in
struct gpio_bank.
Thanks for the patch, will pick up for u-boot-dm.
Acked-by: Simon Glass <sjg@chromium.org>
Regards,
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] gpio: omap: Pass correct argument to _get_gpio_direction()
2015-02-03 0:55 ` Simon Glass
@ 2015-02-06 21:47 ` Simon Glass
0 siblings, 0 replies; 3+ messages in thread
From: Simon Glass @ 2015-02-06 21:47 UTC (permalink / raw)
To: u-boot
On 2 February 2015 at 17:55, Simon Glass <sjg@chromium.org> wrote:
> HI Axel,
>
> On 31 January 2015 at 07:23, Axel Lin <axel.lin@ingics.com> wrote:
>> Pass bank rather than bank->base to _get_gpio_direction().
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>> drivers/gpio/omap_gpio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/omap_gpio.c b/drivers/gpio/omap_gpio.c
>> index f3a7ccb..19fc451 100644
>> --- a/drivers/gpio/omap_gpio.c
>> +++ b/drivers/gpio/omap_gpio.c
>> @@ -291,7 +291,7 @@ static int omap_gpio_get_function(struct udevice *dev, unsigned offset)
>> struct gpio_bank *bank = dev_get_priv(dev);
>>
>> /* GPIOF_FUNC is not implemented yet */
>> - if (_get_gpio_direction(bank->base, offset) == OMAP_GPIO_DIR_OUT)
>> + if (_get_gpio_direction(bank, offset) == OMAP_GPIO_DIR_OUT)
>> return GPIOF_OUTPUT;
>> else
>> return GPIOF_INPUT;
>
> Ah yes another reason why we need a struct rather than void * in
> struct gpio_bank.
>
> Thanks for the patch, will pick up for u-boot-dm.
>
> Acked-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-dm, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-06 21:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-31 14:23 [U-Boot] [PATCH] gpio: omap: Pass correct argument to _get_gpio_direction() Axel Lin
2015-02-03 0:55 ` Simon Glass
2015-02-06 21:47 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox