public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/8] lpc32xx: mtd: nand: add MLC NAND controller
Date: Tue, 10 Mar 2015 13:49:46 -0500	[thread overview]
Message-ID: <1426013386.30327.29.camel@freescale.com> (raw)
In-Reply-To: <20150310135435.5191c96f.albert.aribaud@3adev.fr>

On Tue, 2015-03-10 at 13:54 +0100, Albert ARIBAUD wrote:
> Hi Scott,
> 
> Le Mon, 9 Mar 2015 18:51:03 -0500, Scott Wood <scottwood@freescale.com>
> a ?crit :
> 
> > On Thu, 2015-03-05 at 07:46 +0100, Albert ARIBAUD (3ADEV) wrote:
> > > +	while (left) {
> > > +		if (read_single_page(dst, page) >= 0) {
> > > +			dst += LARGE_PAGE_SIZE;
> > > +			page++;
> > > +			left--;
> > > +		}
> > > +	}
> > 
> > No bad block skipping?
> 
> Hmm... actually the 'left--' should be just after the 'if' block,
> otherwise not only will the code not skip a bad block, it will actually
> loop infinitely trying to read it. Will fix in v4. Thanks for pointing
> this out!

What causes read_single_page() to fail when there's a bad block marker?
Especially if the marker is on a different page of the block.  I'm not
talking about ECC failures (which should not silently be skipped).

-Scott

  reply	other threads:[~2015-03-10 18:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05  6:46 [U-Boot] [PATCH v3 0/8] Extend LPC32xx functionality and add LPC32xx-based work_92015 board Albert ARIBAUD
2015-03-05  6:46 ` [U-Boot] [PATCH v3 1/8] lpc32xx: add Ethernet support Albert ARIBAUD
2015-03-05  6:46   ` [U-Boot] [PATCH v3 2/8] lpc32xx: mtd: nand: add MLC NAND controller Albert ARIBAUD
2015-03-05  6:46     ` [U-Boot] [PATCH v3 3/8] lpc32xx: i2c: add LPC32xx I2C interface support Albert ARIBAUD
2015-03-05  6:46       ` [U-Boot] [PATCH v3 4/8] lpc32xx: add GPIO support Albert ARIBAUD
2015-03-05  6:46         ` [U-Boot] [PATCH v3 5/8] lpc32xx: add LPC32xx SSP support (SPI mode) Albert ARIBAUD
2015-03-05  6:46           ` [U-Boot] [PATCH v3 6/8] dtt: add ds620 support Albert ARIBAUD
2015-03-05  6:46             ` [U-Boot] [PATCH v3 7/8] lpc32xx: add lpc32xx-spl.bin boot image target Albert ARIBAUD
2015-03-05  6:46               ` [U-Boot] [PATCH v3 8/8] lpc32xx: add support for board work_92105 Albert ARIBAUD
2015-03-09 23:51     ` [U-Boot] [PATCH v3 2/8] lpc32xx: mtd: nand: add MLC NAND controller Scott Wood
2015-03-10 12:54       ` Albert ARIBAUD
2015-03-10 18:49         ` Scott Wood [this message]
2015-03-10 20:33           ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426013386.30327.29.camel@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox