[U-Boot] [PATCH v5 08/14] virt-dt: Allow reservation of secure region when in a RAM carveout

Thierry Reding
2015-03-12T08:18:01Z

On Wed, Mar 11, 2015 at 11:12:25AM -0400, Tom Rini wrote:
> * PGP Signed by an unknown key
>
> On Mon, Mar 09, 2015 at 08:00:18AM +0100, Jan Kiszka wrote:
>
> > In this case the secure code lives in RAM, and hence the memory node in
> > the device tree needs to be adjusted. This avoids that the OS will map
> > and possibly access the reservation.
> >
> > Add support for setting CONFIG_ARMV7_SECURE_RESERVE_SIZE to carve out
> > such a region. We only support cutting off memory from the beginning or
> > the end of a RAM bank as we do not want to increase their number (which
> > would happen if punching a hole) for simplicity reasons
> >
> > This will be used in a subsequent patch for Jetson-TK1.
> >
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> > arch/arm/cpu/armv7/virt-dt.c | 29 +++++++++++++++++++++++++++++
>
> My concern here is that this looks a lot like things we would re-use on
> armv8 and we're making them potentially needlessly v7-centric. If
> nothing else, the function names should be generic and this be the v7
> implementation of them, yes?

In my opinion it's fine to go along with this and then refactor things
once we have an ARMv8 board that makes use of this.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150312/d3cc3154/attachment.sig>