From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Kocialkowski Date: Wed, 11 Mar 2015 21:26:43 +0100 Subject: [U-Boot] [PATCH V6 07/11] ARM: OMAP3: Get rid of omap3_gp_romcode_call and replace with omap_smc1 In-Reply-To: References: <1425939129-308-1-git-send-email-nm@ti.com> <1425939129-308-8-git-send-email-nm@ti.com> <20150311154845.GL32541@bill-the-cat> <20150311160028.GR32541@bill-the-cat> Message-ID: <1426105603.2417.4.camel@collins> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le mercredi 11 mars 2015 ? 11:04 -0500, Nishanth Menon a ?crit : > On Wed, Mar 11, 2015 at 11:00 AM, Tom Rini wrote: > > On Wed, Mar 11, 2015 at 10:53:41AM -0500, Nishanth Menon wrote: > >> On Wed, Mar 11, 2015 at 10:48 AM, Tom Rini wrote: > >> > On Mon, Mar 09, 2015 at 05:12:05PM -0500, Nishanth Menon wrote: > >> > > >> >> omap_smc1 is now generic enough to remove duplicate > >> >> omap3_gp_romcode_call logic that omap3 introduced. > >> >> > >> >> As part of this change, move to using the generic lowlevel_init.S for > >> >> omap3 as well. > >> >> > >> >> Signed-off-by: Nishanth Menon > >> > > >> > Reviewed-by: Tom Rini > >> > > >> > But I've always wondered, does OMAP3 not actually pass in the same info > >> > in the same location / manner as OMAP4 and later? > >> > >> For smc call, the calls are similar, but the parameters change > > > > Right, sorry but I mean for boot params as that's what's still being > > omap3-specific in lowlevel_init.S > > There seemed to be differences w.r.t bootdevice detection logic which > seems to be extensive in omap3 :( > had'nt dug too much there :( As far as I can see, the main difference is that omap4/5 are using SRAM to store various bits such as the boot device (OMAP_SRAM_SCRATCH_BOOT_PARAMS). On omap3, that logic is not used and a global variable (omap3_boot_device) is there instead. We could easily make that logic fit omap3 as well and get rid of the global variable. I also see a few functions from omap-common's hwinit-common.c that could be reused on omap3. I could start looking into that, even though again, I don't have many OMAP devices to test with. -- Paul Kocialkowski, Replicant developer Replicant is a fully free Android distribution running on several devices, a free software mobile operating system putting the emphasis on freedom and privacy/security. Website: http://www.replicant.us/ Blog: http://blog.replicant.us/ Wiki/tracker/forums: http://redmine.replicant.us/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: