From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 20/28] armv8/ls2085ardb: Add support of LS2085ARDB platform
Date: Mon, 23 Mar 2015 17:02:49 -0500 [thread overview]
Message-ID: <1427148169.22867.12.camel@freescale.com> (raw)
In-Reply-To: <550CCD84.6010104@freescale.com>
On Fri, 2015-03-20 at 18:46 -0700, York Sun wrote:
>
> On 03/20/2015 05:33 PM, Scott Wood wrote:
> > On Fri, 2015-03-20 at 17:29 -0700, York Sun wrote:
> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> >> index f4a7851..7478eb4 100644
> >> --- a/arch/arm/Kconfig
> >> +++ b/arch/arm/Kconfig
> >> @@ -658,6 +658,16 @@ config TARGET_LS2085AQDS
> >> development platform that supports the QorIQ LS2085A
> >> Layerscape Architecture processor.
> >>
> >> +config TARGET_LS2085ARDB
> >> + bool "Support ls2085ardb"
> >> + select ARM64
> >> + select ARMV8_MULTIENTRY
> >> + help
> >> + Support for Freescale LS2085ARDB platform.
> >> + The LS2080A Reference design board (RDB) is a high-performance
> >> + development platform that supports the QorIQ LS2085A
> >> + LayerScape Architecture processor.
> >> +
> >
> > s/LayerScape/Layerscape/
> >
> >> diff --git a/board/freescale/ls2085aqds/README b/board/freescale/ls2085ardb/README
> >> similarity index 73%
> >> copy from board/freescale/ls2085aqds/README
> >> copy to board/freescale/ls2085ardb/README
> >> index a4d7b53..cfd5185 100644
> >> --- a/board/freescale/ls2085aqds/README
> >> +++ b/board/freescale/ls2085ardb/README
> >> @@ -1,10 +1,8 @@
> >> Overview
> >> --------
> >> -The LS2080A Development System (QDS) is a high-performance computing,
> >> -evaluation, and development platform that supports the QorIQ LS2080A
> >> -LayerScape Architecture processor. The LS2080AQDS provides validation and
> >> -SW development platform for the Freescale LS2080A processor series, with
> >> -a complete debugging environment.
> >> +The LS2085A Reference Design (RDB) is a high-performance computing,
> >> +evaluation, and development platform that supports the QorIQ LS2085A
> >> +Layerscape Architecture processor.
> >
> > "LayerScape" and 2080 should be fixed in the QDS patch as well.
> >
> >> @@ -113,25 +105,25 @@ unsigned long get_board_ddr_clk(void);
> >> #define CONFIG_SYS_NAND_CSOR (CSOR_NAND_ECC_ENC_EN /* ECC on encode */ \
> >> | CSOR_NAND_ECC_DEC_EN /* ECC on decode */ \
> >> | CSOR_NAND_ECC_MODE_4 /* 4-bit ECC */ \
> >> - | CSOR_NAND_RAL_3 /* RAL = 2Byes */ \
> >> - | CSOR_NAND_PGS_2K /* Page Size = 2K */ \
> >> - | CSOR_NAND_SPRZ_64/* Spare size = 64 */ \
> >> - | CSOR_NAND_PB(64)) /*Pages Per Block = 64*/
> >> + | CSOR_NAND_RAL_3 /* RAL = 3Byes */ \
> >> + | CSOR_NAND_PGS_4K /* Page Size = 4K */ \
> >> + | CSOR_NAND_SPRZ_224 /* Spare size = 224 */ \
> >> + | CSOR_NAND_PB(128)) /*Pages Per Block = 128*/
> >
> > From this it looks like the QDS patch still has a comment/code
> > inconsistency with RAL.
> >
>
> Let me re-generate the patch using patman, without -C --find-copies-harder flag
> so they don't show as copy-n-modify.
Why? I found it rather useful. In any case, the error in the QDS file
will still be there.
-SCott
next prev parent reply other threads:[~2015-03-23 22:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 0:29 [U-Boot] [PATCH v4 20/28] armv8/ls2085ardb: Add support of LS2085ARDB platform York Sun
2015-03-21 0:33 ` Scott Wood
2015-03-21 1:46 ` York Sun
2015-03-23 22:02 ` Scott Wood [this message]
2015-03-23 22:04 ` York Sun
2015-03-23 22:08 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427148169.22867.12.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox