public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] sunxi: sun4i: add missing 912MHz clock divisors
Date: Fri, 27 Mar 2015 14:04:53 +0000	[thread overview]
Message-ID: <1427465093.13935.151.camel@hellion.org.uk> (raw)
In-Reply-To: <5514A013.7040300@gmail.com>

On Fri, 2015-03-27 at 00:10 +0000, Iain Paton wrote:
> clock divisors table was missing an entry for 912MHz. The same table is
> used for sun7i where the default boot clock is 912MHz, resulting in A20
> boards being overclocked to 960MHz

Apart from the missing entry, should it not be the case that we pick the
highest frequency <= than the requested frequency, rather than the next
available (potentially higher) frequency?

IOW I'd expect things to be underclocked@768MHz without this change,
which would mean that clock_set_pll1 is buggy.

Ian.

> 
> Signed-off-by: Iain Paton <ipaton0@gmail.com>
> ---
>  arch/arm/cpu/armv7/sunxi/clock_sun4i.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/cpu/armv7/sunxi/clock_sun4i.c b/arch/arm/cpu/armv7/sunxi/clock_sun4i.c
> index 49f4032..c720e96 100644
> --- a/arch/arm/cpu/armv7/sunxi/clock_sun4i.c
> +++ b/arch/arm/cpu/armv7/sunxi/clock_sun4i.c
> @@ -102,6 +102,7 @@ static struct {
>  	/* This array must be ordered by frequency. */
>  	{ PLL1_CFG(16, 0, 0, 0), 384000000 },
>  	{ PLL1_CFG(16, 1, 0, 0), 768000000 },
> +	{ PLL1_CFG(19, 1, 0, 0), 912000000 },
>  	{ PLL1_CFG(20, 1, 0, 0), 960000000 },
>  	{ PLL1_CFG(21, 1, 0, 0), 1008000000},
>  	{ PLL1_CFG(22, 1, 0, 0), 1056000000},

  reply	other threads:[~2015-03-27 14:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27  0:10 [U-Boot] [PATCH 1/3] sunxi: sun4i: add missing 912MHz clock divisors Iain Paton
2015-03-27 14:04 ` Ian Campbell [this message]
2015-03-28 10:24   ` Iain Paton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427465093.13935.151.camel@hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox