From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 30 Mar 2015 23:34:36 -0500 Subject: [U-Boot] [PATCH 1/2] mtd: vf610_nfc: mark page as dirty on block erase In-Reply-To: <1d8481267a40fed73b4aff1a50ae0774@agner.ch> References: <1427216060-29120-1-git-send-email-stefan@agner.ch> <87mw2uo1va.fsf@nbsps.com> <1427747668.22867.174.camel@freescale.com> <1427748489.22867.187.camel@freescale.com> <38e4a435ee5080566042c6021efe7e83@agner.ch> <1427753707.22867.198.camel@freescale.com> <1d8481267a40fed73b4aff1a50ae0774@agner.ch> Message-ID: <1427776476.22867.220.camel@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, 2015-03-31 at 00:24 +0200, Stefan Agner wrote: > Actually, I just realized that the driver is not caching writes. > > switch (command) { > case NAND_CMD_PAGEPROG: > nfc->page = -1; > + vf610_nfc_transfer_size(nfc->regs, nfc->page_sz); > vf610_nfc_send_commands(nfc->regs, NAND_CMD_SEQIN, > command, PROGRAM_PAGE_CMD_CODE); > vf610_nfc_addr_cycle(mtd, column, page); > break; > > The nfc->page = -1 resets the page cache, so the next read triggers a > full page read. > > I will check the performance consequences when disabling cache entirely, > and whether it would be possible to implement a OOB only read. OK. In the meantime I'll apply this. -Scott