public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 06/11] Avoid calling print_eths() with driver model
Date: Sun,  5 Apr 2015 16:07:38 -0600	[thread overview]
Message-ID: <1428271663-3814-7-git-send-email-sjg@chromium.org> (raw)
In-Reply-To: <1428271663-3814-1-git-send-email-sjg@chromium.org>

This function is not supported with driver model.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
---
Note from Joe Hershberger <joe.hershberger@ni.com>

At this point I don't see much value in listing the Ethernet devices in
bdinfo. It seems like a bit of a spurious thing to display and as such I
didn't feel like rewriting it to be compatible with DM or implementing the
functions bdinfo's print_eths() uses.  Also, it is only supported on ARM
and Microblaze. The inconsistency also led to my decision to drop it.

Changes in v2: None

 common/cmd_bdinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
index b4cce25..f16d5c7 100644
--- a/common/cmd_bdinfo.c
+++ b/common/cmd_bdinfo.c
@@ -377,7 +377,7 @@ static int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc,
 		print_num("-> size",	bd->bi_dram[i].size);
 	}
 
-#if defined(CONFIG_CMD_NET)
+#if defined(CONFIG_CMD_NET) && !defined(CONFIG_DM_ETH)
 	print_eths();
 #endif
 	printf("baudrate    = %u bps\n", gd->baudrate);
-- 
2.2.0.rc0.207.ga3a616c

  parent reply	other threads:[~2015-04-05 22:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-05 22:07 [U-Boot] [PATCH v2 0/11] dm: net: Conversion patches for sunxi driver model Ethernet Simon Glass
2015-04-05 22:07 ` [U-Boot] [PATCH v2 01/11] sunxi: Replace the pcDuino3 config with FDT version Simon Glass
2015-04-09  3:00   ` Simon Glass
2015-04-05 22:07 ` [U-Boot] [PATCH v2 02/11] Kconfig: Move CONFIG_DESIGNWARE_ETH to Kconfig Simon Glass
2015-04-09  3:04   ` Simon Glass
2015-04-05 22:07 ` [U-Boot] [PATCH v2 03/11] dts: sunxi: Bring in Ethernet device tree bindings Simon Glass
2015-04-09  3:04   ` Simon Glass
2015-04-05 22:07 ` [U-Boot] [PATCH v2 04/11] dm: core: Support allocating driver-private data for DMA Simon Glass
2015-04-05 22:07 ` [U-Boot] [PATCH v2 05/11] dm: net: Use existing Ethernet init for driver model Simon Glass
2015-04-09  3:04   ` Simon Glass
2015-04-05 22:07 ` Simon Glass [this message]
2015-04-09  3:04   ` [U-Boot] [PATCH v2 06/11] Avoid calling print_eths() with " Simon Glass
2015-04-05 22:07 ` [U-Boot] [PATCH v2 07/11] dm: net: Adjust PHY interface to work with CONFIG_DM_ETH Simon Glass
2015-04-09  3:04   ` Simon Glass
2015-04-05 22:07 ` [U-Boot] [PATCH v2 08/11] dm: net: Tidy up designware driver ready for driver model Simon Glass
2015-04-09  3:04   ` Simon Glass
2015-04-05 22:07 ` [U-Boot] [PATCH v2 09/11] dm: net: Adjust designware driver to support " Simon Glass
2015-04-06 21:09   ` Joe Hershberger
2015-04-09  3:04     ` Simon Glass
2015-04-05 22:07 ` [U-Boot] [PATCH v2 10/11] dm: sunxi: Support driver model for Ethernet Simon Glass
2015-04-09  3:04   ` Simon Glass
2015-04-05 22:07 ` [U-Boot] [PATCH v2 11/11] dm: sunxi: Use driver model for Ethernet on Linksprite pcDuino3 Simon Glass
2015-04-09  3:04   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428271663-3814-7-git-send-email-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox