public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Paul Kocialkowski <contact@paulk.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/3] i2c: mvtwsi: Support for up to 4 different controllers
Date: Tue, 07 Apr 2015 08:35:31 +0200	[thread overview]
Message-ID: <1428388531.2527.0.camel@collins> (raw)
In-Reply-To: <5523794E.2040705@redhat.com>

Le mardi 07 avril 2015 ? 08:29 +0200, Hans de Goede a ?crit :
> Hi,
> 
> On 07-04-15 07:24, Heiko Schocher wrote:
> > Hello Paul,
> >
> > Am 05.04.2015 09:51, schrieb Paul Kocialkowski:
> >> Orion5x, Kirkwood and Armada XP platforms come with a single TWSI (I2C) MVTWSI
> >> controller. However, other platforms using MVTWSI may come with more: this is
> >> the case on Allwinner (sunxi) platforms, where up to 4 controllers can be found
> >> on the same chip.
> >>
> >> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> >> ---
> >>   arch/arm/include/asm/arch-sunxi/i2c.h        |   2 +-
> >>   arch/arm/mach-kirkwood/include/mach/config.h |   2 +-
> >>   drivers/i2c/mvtwsi.c                         | 124 ++++++++++++++++++++-------
> >>   include/configs/db-mv784mp-gp.h              |   2 +-
> >>   include/configs/edminiv2.h                   |   2 +-
> >>   include/configs/maxbcm.h                     |   2 +-
> >>   6 files changed, 100 insertions(+), 34 deletions(-)
> >
> > Thanks for your work. No comments from me, beside of the fact,
> > that it would be nice if we could switch to use DM ;-)
> >
> > Acked-by: Heiko Schocher <hs@denx.de>
> >
> > @Hans: please pick up the hole series, thanks!
> 
> Ok will do so as soon as there is a V4 addressing my last review
> comment.

Okay, I'll be submitting v4 soon then. Then it'll be time to take a
close look at driver-model and device-tree!

> Regards,
> 
> Hans

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150407/d82d14bc/attachment.sig>

  reply	other threads:[~2015-04-07  6:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-05  7:51 [U-Boot] [PATCH v3 0/3] i2c: sunxi: Support every i2c controller on each supported platform Paul Kocialkowski
2015-04-05  7:51 ` [U-Boot] [PATCH v3 1/3] i2c: mvtwsi: Support for up to 4 different controllers Paul Kocialkowski
2015-04-07  5:24   ` Heiko Schocher
2015-04-07  6:29     ` Hans de Goede
2015-04-07  6:35       ` Paul Kocialkowski [this message]
2015-04-05  7:51 ` [U-Boot] [PATCH v3 2/3] sunxi: Complete i2c support for each supported platform Paul Kocialkowski
2015-04-05  7:51 ` [U-Boot] [PATCH v3 3/3] sunxi: I2C/TWI configs for a few single-board-computers Paul Kocialkowski
2015-04-05  8:44 ` [U-Boot] [PATCH v3 0/3] i2c: sunxi: Support every i2c controller on each supported platform Hans de Goede
2015-04-05 20:59   ` Paul Kocialkowski
2015-04-07  7:51     ` Paul Kocialkowski
2015-04-07  9:09       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428388531.2527.0.camel@collins \
    --to=contact@paulk.fr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox