From: Paul Kocialkowski <contact@paulk.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 0/3] i2c: sunxi: Support every i2c controller on each supported platform
Date: Wed, 08 Apr 2015 13:05:06 +0200 [thread overview]
Message-ID: <1428491106.4545.2.camel@collins> (raw)
In-Reply-To: <1428438001-22061-1-git-send-email-contact@paulk.fr>
Actually, I'd prefer that you do not merge this since some ifdef logic
around controller 0 is still missing and mvtwsi code still assumes that
controller 0 will be defined. It may be the case that users wish to only
enable controller [1-4]. I think the Kconfig logic is also not necessary
and not a great addition to have since sunxi will be the sole user of it
(while other boards will keep using the option defined in the config
header). I'll work those issues out soon and provide a v5.
What do you think about all this?
Le mardi 07 avril 2015 ? 22:19 +0200, Paul Kocialkowski a ?crit :
> Changes since v3:
> * Kconfig support for MVTWSI
> * Only enable twsi0 by default for platforms that always use it for the AXP
> * Remove enabling other I2C busses by default on boards that expose them on pin
> headers since those might be used for some other functionalities
>
> Changes since v2:
> * I2C/TWI busses enable for Cubietruck as well
>
> Changes since v1:
> * Kconfig option to enable I2C/TWI controllers 1-4 (when applicable)
> * Following patch to enable exposed busses on a few community-supported
> single-board-computers
>
> This series adds support for every i2c controller found on
> sun4i/sun5i/sun6i/sun7i/sun8i platforms and shouldn't break support for Marvell
> platforms (orion5x, kirkwood, armada xp) the driver was originally written for.
>
> Regarding sunxi, I double-checked that this doesn't conflict with
> VIDEO_LCD_PANEL_I2C.
>
> I would be interested in having this tested on sun8i (A23), since I changed TWI0
> muxing (to PH2-PH3 instead of PB0-PB1), according to the user manual and what
> is being done on the upstream Linux kernel. I2C was either not working before,
> or it was being muxed correctly by the bootrom, probably to communicate with the
> AXP, which luckily made it work in U-Boot too, since the I/O base address was
> already correct.
>
> My use case here is that I'm writing a slave-side bitbang i2c implementation
> (with an Arduino) for a school project, using a Cubieboard2 as master and
> U-Boot as POC. However, only TWI1 was available through the expansion pins,
> hence the need for this series.
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150408/6262202c/attachment.sig>
next prev parent reply other threads:[~2015-04-08 11:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 20:19 [U-Boot] [PATCH v4 0/3] i2c: sunxi: Support every i2c controller on each supported platform Paul Kocialkowski
2015-04-07 20:19 ` [U-Boot] [PATCH v4 1/3] i2c: mvtwsi: Support for up to 4 different controllers Paul Kocialkowski
2015-04-07 20:20 ` [U-Boot] [PATCH v4 2/3] i2c: MVTWSI driver Kconfig bindings Paul Kocialkowski
2015-04-07 20:42 ` Paul Kocialkowski
2015-04-07 20:20 ` [U-Boot] [PATCH v4 3/3] sunxi: Complete i2c support for each supported platform Paul Kocialkowski
2015-04-08 11:05 ` Paul Kocialkowski [this message]
2015-04-08 11:52 ` [U-Boot] [PATCH v4 0/3] i2c: sunxi: Support every i2c controller on " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428491106.4545.2.camel@collins \
--to=contact@paulk.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox