From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?J=F6rg?= Krause <joerg.krause@embedded.rocks>
Date: Tue, 14 Apr 2015 08:29:11 +0200
Subject: [U-Boot] [PATCH v2 3/4] mtd: nand: mxs: Add comment for
 calculating ECC strength
In-Reply-To: <552CAFE5.409@denx.de>
References: <1428956274-18362-1-git-send-email-joerg.krause@embedded.rocks>
 <1428956274-18362-4-git-send-email-joerg.krause@embedded.rocks>
 <552CAFE5.409@denx.de>
Message-ID: <1428992951.2266.6.camel@embedded.rocks>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Heiko,

On Di, 2015-04-14 at 08:12 +0200, Heiko Schocher wrote:
> Hello J?rg,
> 
> Am 13.04.2015 22:17, schrieb J?rg Krause:
> > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> > ---
> >   drivers/mtd/nand/mxs_nand.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> 
> nitpick only ...

I'm unsure what this comment means translated to German. Something
like small changes only?

> 
> > diff --git a/drivers/mtd/nand/mxs_nand.c 
> > b/drivers/mtd/nand/mxs_nand.c
> > index 912fed8..76e47ab 100644
> > --- a/drivers/mtd/nand/mxs_nand.c
> > +++ b/drivers/mtd/nand/mxs_nand.c
> > @@ -148,6 +148,13 @@ static inline uint32_t 
> > mxs_nand_get_ecc_strength(uint32_t page_data_size,
> >   {
> >     int ecc_strength;
> > 
> > +   /* Determine the ECC layout with the formula:
> 
> wrong comment style ... please fix also in patch 4/4... thanks.

Checkpatch did not complain and I did not know there is a coding style
for comments. Should it be:
    /*
     * Determine the ECC layout...

Bye
J?rg