From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 2/4] mtd, nand: move common functions from cmd_nand.c to common place
Date: Mon, 27 Apr 2015 18:49:30 -0500 [thread overview]
Message-ID: <1430178570.16357.54.camel@freescale.com> (raw)
In-Reply-To: <1430113328-29184-3-git-send-email-hs@denx.de>
On Mon, 2015-04-27 at 07:42 +0200, Heiko Schocher wrote:
> move common functions from cmd_nand.c (for calculating offset
> and size from cmdline paramter) to common place, so they could
> used from other commands which use mtd partitions.
>
> For onenand the arg_off_size() is left in common/cmd_onenand.c.
> It should use now the common arg_off() function, but as I could
> not test onenand I let it there ...
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
>
> ---
>
> Changes in v6: None
> Changes in v2:
> - none
> Series-changes: 3
> - add comments from scott wood:
> - align MTD_DEV_TYPE_NAND correct
> - remove unnecessary inline
> - rework "jffs2 header" problem later
> - rebase with d6c1ffc7d23f4fe4ae8c91101861055b8e1501b6
> Series-changes: 4
> - rebased against 385a08a60f042061b004642d6b9bb6cfb794ad5a
> Series-changes: 5
> - add comment from Scott Wood:
> keep the continuation line aligned with the arguments
> Series-changes: 6
> - add Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
> - fix Tom Rinis mail addr
> - add comment from Scott Wood:
> - fix indentation level
> - add mtd_ prefix
> - move str2off and str2long into common place, as they are no
> mtd specific functions and change return value from int to bool
>
> common/cmd_nand.c | 148 ++++++++++--------------------------------------
> common/cmd_onenand.c | 19 ++-----
> common/cmd_test.c | 12 +---
> drivers/mtd/Makefile | 4 +-
> drivers/mtd/mtd_uboot.c | 99 ++++++++++++++++++++++++++++++++
> include/linux/mtd/mtd.h | 5 ++
> include/vsprintf.h | 2 +
> lib/vsprintf.c | 16 ++++++
> 8 files changed, 164 insertions(+), 141 deletions(-)
> create mode 100644 drivers/mtd/mtd_uboot.c
Acked-by: Scott Wood <scottwood@freescale.com>
-Scott
next prev parent reply other threads:[~2015-04-27 23:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 5:42 [U-Boot] [PATCH v6 0/4] spi, sf: add mtdparts feature to spi and sf commands Heiko Schocher
2015-04-27 5:42 ` [U-Boot] [PATCH v6 1/4] mtd, spi: add MTD layer driver Heiko Schocher
2015-05-19 20:09 ` Jagan Teki
2015-05-20 6:46 ` Heiko Schocher
2015-06-16 8:04 ` Jagan Teki
2015-06-16 8:43 ` Heiko Schocher denx
2015-06-16 8:52 ` Jagan Teki
2015-06-16 9:18 ` Heiko Schocher denx
2015-06-16 9:36 ` Jagan Teki
2015-06-16 10:06 ` Daniel Schwierzeck
2015-06-22 6:43 ` Jagan Teki
2015-06-22 11:53 ` Daniel Schwierzeck
2015-06-22 19:59 ` Jagan Teki
2015-04-27 5:42 ` [U-Boot] [PATCH v6 2/4] mtd, nand: move common functions from cmd_nand.c to common place Heiko Schocher
2015-04-27 23:49 ` Scott Wood [this message]
2015-04-27 5:42 ` [U-Boot] [PATCH v6 3/4] spi, sf: use offset and size in sf cmd from mtdpartition Heiko Schocher
2015-04-27 5:42 ` [U-Boot] [PATCH v6 4/4] mtd, spi: check if flash pointer is used Heiko Schocher
2015-05-11 5:49 ` [U-Boot] [PATCH v6 0/4] spi, sf: add mtdparts feature to spi and sf commands Heiko Schocher
2015-05-11 6:01 ` Jagan Teki
2015-05-11 6:10 ` Heiko Schocher
2015-06-16 4:30 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430178570.16357.54.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox