From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] nand: fix buffer alignment in new verification feature
Date: Wed, 29 Apr 2015 18:23:24 -0500 [thread overview]
Message-ID: <1430349804.16357.116.camel@freescale.com> (raw)
In-Reply-To: <55414B0A.2060603@wwwdotorg.org>
On Wed, 2015-04-29 at 15:20 -0600, Stephen Warren wrote:
> On 04/14/2015 08:59 AM, Stephen Warren wrote:
> > From: Stephen Warren <swarren@nvidia.com>
> >
> > On systems with caches enabled, NAND I/O may need to flush/invalidate
> > the cache during read/write operations. For this to work correctly, all
> > buffers must be cache-aligned. Fix nand_verify*() to allocate aligned
> > buffers.
> >
> > This prevents cache alignment warnings from being spewed when using
> > U-Boot to write an updated version of itself to flash on NVIDIA Tegra
> > Seaboard (after perturbation of stack/data layout in current
> > u-boot-dm/next branch).
> >
> > I have validatd (executed) nand_verify(), but I don't think I've executed
> > nand_verify_page_oob(); testing of that would be useful.
> >
> > Cc: Peter Tyser <ptyser@xes-inc.com>
> > Cc: Heiko Schocher <hs@denx.de>
> > Cc: Scott Wood <scottwood@freescale.com>
> > Fixes: 59b5a2ad83df ("nand: Add verification functions")
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
> > ---
> > v2: Use memalign() rather than ALLOC_CACHE_ALIGN_BUFFER() so that the
> > buffer is allocated from the heap not on the stack, to reduce stack
> > usage.
>
> Scott, does this version look good?
Yes. I'll apply it the next time I look at U-Boot patches, or if you
want it faster:
Acked-by: Scott Wood <scottwood@freescale.com>
-Scott
prev parent reply other threads:[~2015-04-29 23:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 14:59 [U-Boot] [PATCH V2] nand: fix buffer alignment in new verification feature Stephen Warren
2015-04-14 22:45 ` Simon Glass
2015-04-29 21:20 ` Stephen Warren
2015-04-29 23:23 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430349804.16357.116.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox