From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 08/10] sunxi: Add basic A33 basic support
Date: Sat, 02 May 2015 14:36:33 +0100 [thread overview]
Message-ID: <1430573793.15640.105.camel@hellion.org.uk> (raw)
In-Reply-To: <1430074357-31590-1-git-send-email-hdegoede@redhat.com>
On Sun, 2015-04-26 at 20:52 +0200, Hans de Goede wrote:
> From: Vishnu Patekar <vishnupatekar0510@gmail.com>
>
> Enable full support for the A33 SoC including display, otg-usb, etc.
>
> Signed-off-by: Vishnu Patekar <vishnupatekar0510@gmail.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Ian Campbell <ijc@hellion.org.uk>
> -#if defined(CONFIG_MACH_SUN8I_A23)
> +#if defined(CONFIG_MACH_SUN8I_A23) || defined(CONFIG_MACH_SUN8I_A33)
There's a lot of these A23||A33 (and !A23&&!A33). Perhaps a hidden
MACH_SUN8I_COMMON selected by both would be helpful?
With or without the _COMMON suffix as you prefer, although without would
remove 90% of the changes in this patch.
Can defer it until later if you prefer, or you may retain my ack if you
want to make the change in the obvious way.
Ian.
next prev parent reply other threads:[~2015-05-02 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-26 18:52 [U-Boot] [PATCH v2 08/10] sunxi: Add basic A33 basic support Hans de Goede
2015-05-02 13:36 ` Ian Campbell [this message]
2015-05-04 9:26 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430573793.15640.105.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox