From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/8] sunxi: ehci: Convert to the driver-model
Date: Sat, 02 May 2015 15:04:24 +0100 [thread overview]
Message-ID: <1430575464.15640.124.camel@hellion.org.uk> (raw)
In-Reply-To: <1430575410.15640.123.camel@hellion.org.uk>
On Sat, 2015-05-02 at 15:03 +0100, Ian Campbell wrote:
I see I missed v2, oh well, this bit of code looks the same AFAICT.
> On Thu, 2015-04-30 at 16:35 +0200, Hans de Goede wrote:
> > + if (hccr == (void *)SUNXI_USB1_BASE) {
> > + priv->ahb_gate_mask = 1 << AHB_GATE_OFFSET_USB_EHCI0;
> > + priv->phy_index = 1;
>
> Inferring these from the base address is a bit unfortunate, should we
> not get told this by the DT, or from something higher up?
>
> I have a feeling the answer will be "this can go away when X, Y & X have
> happened", in which case perhaps a comment to that affect?
>
> BTW I ignored patches 1..7 based on the diffstats, please let me know if
> I should take a look for some reason.
>
> Ian.
next prev parent reply other threads:[~2015-05-02 14:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 14:35 [U-Boot] [PATCH 0/8] usb: driver-model fixes and dm support sunxi-ehci.c Hans de Goede
2015-04-30 14:35 ` [U-Boot] [PATCH 1/8] dm: usb: Copy over usb_device values from usb_scan_device() to final usb_device Hans de Goede
2015-05-01 4:11 ` Simon Glass
2015-05-01 7:21 ` Hans de Goede
2015-05-01 8:03 ` Hans de Goede
2015-04-30 14:35 ` [U-Boot] [PATCH 2/8] dm: usb: Use controller_dev in dm ehci code Hans de Goede
2015-05-01 4:11 ` Simon Glass
2015-05-01 8:03 ` Hans de Goede
2015-04-30 14:35 ` [U-Boot] [PATCH 3/8] dm: usb: Store usb_device parent pointer in usb_device Hans de Goede
2015-05-01 4:11 ` Simon Glass
2015-05-01 8:26 ` Hans de Goede
2015-04-30 14:35 ` [U-Boot] [PATCH 4/8] dm: usb: Set desc_before_addr from ehci dm code Hans de Goede
2015-05-01 4:12 ` Simon Glass
2015-04-30 14:35 ` [U-Boot] [PATCH 5/8] dm: usb: Add support for interrupt queues to the dm usb code Hans de Goede
2015-05-01 4:12 ` Simon Glass
2015-04-30 14:35 ` [U-Boot] [PATCH 6/8] dm: usb: Prefix ehci interrupt-queue functions with _ehci_ Hans de Goede
2015-05-01 4:12 ` Simon Glass
2015-04-30 14:35 ` [U-Boot] [PATCH 7/8] dm: usb: Add support for interrupt queues to the dm ehci code Hans de Goede
2015-05-01 4:12 ` Simon Glass
2015-04-30 14:35 ` [U-Boot] [PATCH 8/8] sunxi: ehci: Convert to the driver-model Hans de Goede
2015-05-01 4:12 ` Simon Glass
2015-05-01 8:37 ` Hans de Goede
2015-05-02 14:03 ` Ian Campbell
2015-05-02 14:04 ` Ian Campbell [this message]
2015-05-04 14:16 ` Hans de Goede
2015-04-30 14:39 ` [U-Boot] [PATCH 0/8] usb: driver-model fixes and dm support sunxi-ehci.c Hans de Goede
2015-04-30 14:48 ` Simon Glass
2015-04-30 19:38 ` Hans de Goede
2015-04-30 22:04 ` Simon Glass
2015-05-01 7:17 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430575464.15640.124.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox