public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jagan Teki <jteki@openedev.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/5] spi: Remove #define BIT in local file
Date: Sun, 10 May 2015 20:52:07 +0530	[thread overview]
Message-ID: <1431271330-7169-3-git-send-email-jteki@openedev.com> (raw)
In-Reply-To: <1431271330-7169-1-git-send-email-jteki@openedev.com>

Since BIT macro is visiable to include/common.h there is no
need to define again it on local headers hence removed.

Signed-off-by: Jagan Teki <jteki@openedev.com>
---
 drivers/spi/davinci_spi.c | 2 --
 drivers/spi/ep93xx_spi.c  | 6 +-----
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c
index 0a036cc..0bd4f88 100644
--- a/drivers/spi/davinci_spi.c
+++ b/drivers/spi/davinci_spi.c
@@ -15,8 +15,6 @@
 #include <asm/io.h>
 #include <asm/arch/hardware.h>
 
-#define BIT(x)			(1 << (x))
-
 /* SPIGCR0 */
 #define SPIGCR0_SPIENA_MASK	0x1
 #define SPIGCR0_SPIRST_MASK	0x0
diff --git a/drivers/spi/ep93xx_spi.c b/drivers/spi/ep93xx_spi.c
index 235557e..cdf30bb 100644
--- a/drivers/spi/ep93xx_spi.c
+++ b/drivers/spi/ep93xx_spi.c
@@ -9,15 +9,11 @@
  */
 
 #include <common.h>
-#include <spi.h>
 #include <malloc.h>
-
+#include <spi.h>
 #include <asm/io.h>
-
 #include <asm/arch/ep93xx.h>
 
-
-#define BIT(x)			(1<<(x))
 #define SSPBASE			SPI_BASE
 
 #define SSPCR0			0x0000
-- 
1.9.1

  parent reply	other threads:[~2015-05-10 15:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-10 15:22 [U-Boot] [PATCH v2 0/5] Introduce BIT and GENMASK Jagan Teki
2015-05-10 15:22 ` [U-Boot] [PATCH v2 1/5] spi/sf: Add BIT macro in linux/bitops.h Jagan Teki
2015-05-10 15:22 ` Jagan Teki [this message]
2015-05-10 15:22 ` [U-Boot] [PATCH v2 3/5] spi/sf: Use BIT macro from linux/bitops.h Jagan Teki
2015-05-10 15:22 ` [U-Boot] [PATCH v2 4/5] linux/bitops.h: GENMASK copy from linux Jagan Teki
2015-05-10 15:22 ` [U-Boot] [PATCH v2 5/5] spi: Use GENMASK instead of numeric hexcodes Jagan Teki
2015-05-12 11:25 ` [U-Boot] [PATCH v2 0/5] Introduce BIT and GENMASK Jagan Teki
2015-05-12 11:33   ` Marek Vasut
2015-05-12 15:02     ` Tom Rini
2015-05-12 15:23       ` Marek Vasut
2015-05-13  1:48         ` Simon Glass
2015-05-15 19:19           ` Jagan Teki
2015-05-15 19:46       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431271330-7169-3-git-send-email-jteki@openedev.com \
    --to=jteki@openedev.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox