From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] sunxi: Make dram odt-en configurable through Kconfig for A33 based boards
Date: Wed, 13 May 2015 20:26:20 +0100 [thread overview]
Message-ID: <1431545180.5748.25.camel@hellion.org.uk> (raw)
In-Reply-To: <1431529774-26822-2-git-send-email-hdegoede@redhat.com>
On Wed, 2015-05-13 at 17:09 +0200, Hans de Goede wrote:
> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
> index 940b6c7..d4ae6c7 100644
> --- a/board/sunxi/Kconfig
> +++ b/board/sunxi/Kconfig
> @@ -95,6 +95,14 @@ config DRAM_ZQ
> ---help---
> Set the dram zq value.
>
> +if MACH_SUN8I_A33
Shouldn't this be a "depends on MACH_SUN8I_A33" in the entry itself? I
see we use if a lot in this file, is there a reason for that or just how
it has been done?
In any case using if here is at least consistent so no strong objection
on that grounds.
> +config DRAM_ODT_EN
> + int "sunxi dram odt enable"
> + default 0
> + ---help---
> + Set this to 1 to enable dram odt (on die termination)
Why is this an int rather than a bool?
next prev parent reply other threads:[~2015-05-13 19:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 15:09 [U-Boot] [PATCH 1/2] sunxi: Fix dram initialization not working on some a33 devices Hans de Goede
2015-05-13 15:09 ` [U-Boot] [PATCH 2/2] sunxi: Make dram odt-en configurable through Kconfig for A33 based boards Hans de Goede
2015-05-13 19:26 ` Ian Campbell [this message]
2015-05-14 16:55 ` Hans de Goede
2015-05-14 18:41 ` Ian Campbell
2015-05-15 18:02 ` Hans de Goede
2015-05-13 19:22 ` [U-Boot] [PATCH 1/2] sunxi: Fix dram initialization not working on some a33 devices Ian Campbell
2015-05-18 10:30 ` Siarhei Siamashka
2015-05-18 10:56 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431545180.5748.25.camel@hellion.org.uk \
--to=ijc+uboot@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox