From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Date: Wed, 13 May 2015 20:26:20 +0100 Subject: [U-Boot] [PATCH 2/2] sunxi: Make dram odt-en configurable through Kconfig for A33 based boards In-Reply-To: <1431529774-26822-2-git-send-email-hdegoede@redhat.com> References: <1431529774-26822-1-git-send-email-hdegoede@redhat.com> <1431529774-26822-2-git-send-email-hdegoede@redhat.com> Message-ID: <1431545180.5748.25.camel@hellion.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 2015-05-13 at 17:09 +0200, Hans de Goede wrote: > diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig > index 940b6c7..d4ae6c7 100644 > --- a/board/sunxi/Kconfig > +++ b/board/sunxi/Kconfig > @@ -95,6 +95,14 @@ config DRAM_ZQ > ---help--- > Set the dram zq value. > > +if MACH_SUN8I_A33 Shouldn't this be a "depends on MACH_SUN8I_A33" in the entry itself? I see we use if a lot in this file, is there a reason for that or just how it has been done? In any case using if here is at least consistent so no strong objection on that grounds. > +config DRAM_ODT_EN > + int "sunxi dram odt enable" > + default 0 > + ---help--- > + Set this to 1 to enable dram odt (on die termination) Why is this an int rather than a bool?