[U-Boot] [PATCH 2/2] sunxi: Make dram odt-en configurable through Kconfig for A33 based boards

Ian Campbell
2015-05-14T18:41:21Z

On Thu, 2015-05-14 at 18:55 +0200, Hans de Goede wrote:
> >> +config DRAM_ODT_EN
> >> + int "sunxi dram odt enable"
> >> + default 0
> >> + ---help---
> >> + Set this to 1 to enable dram odt (on die termination)
> >
> > Why is this an int rather than a bool?
>
> Because it is used directly as an int in the code, otherwise I
> need to add #ifdef-ery. I guess I could make it a bool and use
> IS_ENABLED(), but that does lead to slightly less readable code
> IMHO.

I'm afraid I think IS_ENABLED is the way to go though, it's the lesser
of two evils compared with using an int for a boolean option.

Ian.