From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ijc@hellion.org.uk>
Date: Thu, 21 May 2015 20:02:30 +0100
Subject: [U-Boot] [PATCH 2/2] nand: sunxi: Add support for booting from
 internal NAND memory
In-Reply-To: <555E2665.6060202@redhat.com>
References: <1432216765-8421-1-git-send-email-r.spliet@ultimaker.com>
 <1432216765-8421-3-git-send-email-r.spliet@ultimaker.com>
 <555E2665.6060202@redhat.com>
Message-ID: <1432234950.5748.131.camel@hellion.org.uk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, 2015-05-21 at 20:39 +0200, Hans de Goede wrote:
[...]
> Please create a struct reflecting the register layout and
> then initialize a ptr to this struct from the base-address
> and get register addresses this way, this is how we deal
> with this in pretty much all other sunxi code, see e.g.:

This isn't just sunxi, I believe it is u-boot's preferred way to do
things generally.
[...]
> Otherwise this looks like a good start, with the coding
> style issues fixed I would not be opposed against merging
> this as a first step to growing proper nand support.
> 
> Ian, is that ok with you ?

You mean with the coding style fixed but not (necessarily) all the other
issues you pointed out (timeouts on loops, structs for register
accesses)?

I think at least the structs for register access stuff should be fixed
first, especially given it was already raised in the previous round of
review.

Ian