public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/6] sunxi: Update sunxi-common.h to deal with different A1-SRAM base addr on sun9i
Date: Fri, 22 May 2015 07:32:05 +0100	[thread overview]
Message-ID: <1432276325.5748.137.camel@hellion.org.uk> (raw)
In-Reply-To: <555E5BD5.8080306@redhat.com>

On Fri, 2015-05-22 at 00:27 +0200, Hans de Goede wrote:
> Hi,
> 
> On 21-05-15 21:07, Ian Campbell wrote:
> > On Wed, 2015-05-20 at 15:35 +0200, Hans de Goede wrote:
> >> The A1 SRAM Base differs between sun9i and the others, update sunxi-common.h
> >> to deal with this, so that we do not set the initial stack pointer to point
> >> to the BROM.
> >>
> >> This removes the need for the weird undocumented register write I took from
> >> the allwiner u-boot sources and which needed #ifdef-ery in start.S as it
> >> needed to be done really early on.
> >
> > (typo: "allwinner")
> >
> > Removes in the sense that it simply no longer appears in the series, I
> > think? (As opposed to a removal hunk being missing from this or a
> > subsequent patch)
> 
> Correct, remove as in simply no longer appears in the series.

Perhaps s/removes/avoids/ and s/write I took/write I previously took/ to
clarify?

Ack regardless.

> 
> Regsrds,
> 
> Hans
> 
> >
> > Assuming that is the case:
> >
> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >
> > Acked-by: Ian Campbell <ijc@hellion.org.uk>
> >
> 

  reply	other threads:[~2015-05-22  6:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20 13:35 [U-Boot] [PATCH v2 0/6] sunxi: Allwinner A80 SoC support Hans de Goede
2015-05-20 13:35 ` [U-Boot] [PATCH v2 1/6] sunxi: Use axp221 sid on a33 Hans de Goede
2015-05-21 19:03   ` Ian Campbell
2015-05-20 13:35 ` [U-Boot] [PATCH v2 2/6] sunxi: Remove support for building "old-fashioned" fel binaries Hans de Goede
2015-05-21 19:04   ` Ian Campbell
2015-05-22 14:55     ` Hans de Goede
2015-05-20 13:35 ` [U-Boot] [PATCH v2 3/6] sunxi: Update sunxi-common.h to deal with different DRAM base addr on sun9i Hans de Goede
2015-05-21 19:05   ` Ian Campbell
2015-05-20 13:35 ` [U-Boot] [PATCH v2 4/6] sunxi: Update sunxi-common.h to deal with different A1-SRAM " Hans de Goede
2015-05-21 19:07   ` Ian Campbell
2015-05-21 22:27     ` Hans de Goede
2015-05-22  6:32       ` Ian Campbell [this message]
2015-05-22 14:58         ` Hans de Goede
2015-05-20 13:35 ` [U-Boot] [PATCH v2 5/6] sun9i: Basic sun9i (A80) support Hans de Goede
2015-05-20 13:35 ` [U-Boot] [PATCH v2 6/6] sun9i: Add Merrii_A80_Optimus board / defconfig file Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432276325.5748.137.camel@hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox