public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Paul Kocialkowski <contact@paulk.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spl: spl_mmc: fix mmc Falcon mode regression
Date: Fri, 22 May 2015 12:13:30 +0200	[thread overview]
Message-ID: <1432289610.2510.30.camel@collins> (raw)
In-Reply-To: <1432249036-2785-1-git-send-email-tharvey@gateworks.com>

Le jeudi 21 mai 2015 ? 15:57 -0700, Tim Harvey a ?crit :
> 91199f4a5a21a7cf9dd9e7c05e295a042f8c2b7e broke mmc based Falcon mode.
> 
> The block_read function returns the number of blocks read thus the error
> check needs to look for a return of 0 blocks read.

Damn, it seems that I messed up return code checks. My sincerest
apologies for that.

I will check for other potential mistakes introduced by that commit.

> Cc: Paul Kocialkowski <contact@paulk.fr>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>

Acked-by: Paul Kocialkowski <contact@paulk.fr>

> ---
>  common/spl/spl_mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c
> index 5d688d6..c96345e 100644
> --- a/common/spl/spl_mmc.c
> +++ b/common/spl/spl_mmc.c
> @@ -76,7 +76,7 @@ static int mmc_load_image_raw_os(struct mmc *mmc)
>  					CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR,
>  					CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTORS,
>  					(void *)CONFIG_SYS_SPL_ARGS_ADDR);
> -	if (err) {
> +	if (err == 0) {
>  #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
>  		printf("spl: mmc block read error\n");
>  #endif

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150522/a1d5b8f4/attachment.sig>

  reply	other threads:[~2015-05-22 10:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 22:57 [U-Boot] [PATCH] spl: spl_mmc: fix mmc Falcon mode regression Tim Harvey
2015-05-22 10:13 ` Paul Kocialkowski [this message]
2015-05-26 12:27 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432289610.2510.30.camel@collins \
    --to=contact@paulk.fr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox