From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: usb_phy: Swap check for disconnect threshold
Date: Mon, 01 Jun 2015 19:09:29 +0100 [thread overview]
Message-ID: <1433182169.5748.282.camel@hellion.org.uk> (raw)
In-Reply-To: <1433170911-13559-1-git-send-email-hdegoede@redhat.com>
On Mon, 2015-06-01 at 17:01 +0200, Hans de Goede wrote:
> Before this commit the code for determining the disconnect threshold was
> checking for sun4i or sun6i assuming that those where the exception and
> that newer SoCs use a disconnect threshold of 2 like sun7i does.
>
> But it turns out that newer SoCs actually use a disconnect threshold of 3
> and sun5i and sun7i are the exceptions, so check for those instead.
>
> Here are the settings from the various Allwinner SDK sources:
> sun4i-a10: USBC_Phy_Write(usbc_no, 0x2a, 3, 2);
> sun5i-a13: USBC_Phy_Write(usbc_no, 0x2a, 2, 2);
> sun6i-a31: USBC_Phy_Write(usbc_no, 0x2a, 3, 2);
> sun7i-a20: USBC_Phy_Write(usbc_no, 0x2a, 2, 2);
> sun8i-a23: USBC_Phy_Write(usbc_no, 0x2a, 3, 2);
> sun8i-h3: USBC_Phy_Write(usbc_no, 0x2a, 3, 2);
> sun9i-a80: USBC_Phy_Write(usbc_no, 0x2a, 3, 2);
>
> Note this commit makes no functional changes for sun4i - sun7i, and
> changes the disconnect threshold for sun8i to match what Allwinner uses.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Ian Campbell <ijc@hellion.org.uk>
prev parent reply other threads:[~2015-06-01 18:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 15:01 [U-Boot] [PATCH] sunxi: usb_phy: Swap check for disconnect threshold Hans de Goede
2015-06-01 18:09 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433182169.5748.282.camel@hellion.org.uk \
--to=ijc+uboot@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox