From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Kocialkowski Date: Sun, 07 Jun 2015 15:12:41 +0200 Subject: [U-Boot] [PATCH] Bananapi: Fix ethernet device initialization In-Reply-To: <1433682296-41814-1-git-send-email-maxin.john@enea.com> References: <1433682296-41814-1-git-send-email-maxin.john@enea.com> Message-ID: <1433682761.2497.45.camel@collins> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, > Ethernet device initialization fails with the following message: > Net: PH: dir_output: error: gpio PH23 not reserved > Phy 1 not found > PHY reset timed out > eth0: ethernet at 01c50000 > > Tested on Banana Pi board. > > Signed-off-by: Maxin B. John > --- > arch/arm/cpu/armv7/sunxi/board.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/cpu/armv7/sunxi/board.c b/arch/arm/cpu/armv7/sunxi/board.c > index a82c8b9..030a711 100644 > --- a/arch/arm/cpu/armv7/sunxi/board.c > +++ b/arch/arm/cpu/armv7/sunxi/board.c > @@ -223,6 +223,7 @@ int cpu_eth_init(bd_t *bis) > __maybe_unused int rc; > > #ifdef CONFIG_MACPWR > + gpio_request(CONFIG_MACPWR, "MAC Power"); I suggest using the string "macpwr" instead to be consistent with: board/sunxi/ahci.c: gpio_request(CONFIG_SATAPWR, "satapwr"); Good find otherwise! > gpio_direction_output(CONFIG_MACPWR, 1); > mdelay(200); > #endif -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: