From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] sunxi: musb: Remove unused sunxi_musb_exit method
Date: Sun, 14 Jun 2015 12:47:44 +0100 [thread overview]
Message-ID: <1434282464.29215.9.camel@hellion.org.uk> (raw)
In-Reply-To: <1434278413-21157-3-git-send-email-hdegoede@redhat.com>
On Sun, 2015-06-14 at 12:40 +0200, Hans de Goede wrote:
> Remove the unused sunxi_musb_exit method, there is no code in u-boot
> calling the exit method, and our implementation was broken as it did
> not disable the clocks and asserted reset.
Seems to me the call should either be called (and the hooks fixed) or
removed from the core but so far as sunxi goes:
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Ian Campbell <ijc@hellion.org.uk>
next prev parent reply other threads:[~2015-06-14 11:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 10:40 [U-Boot] [PATCH 0/2] sunxi: musb: Fix "usb reset" handling Hans de Goede
2015-06-14 10:40 ` [U-Boot] [PATCH 1/2] sunxi: musb: Do not fully reset the controler from sunxi_musb_disable Hans de Goede
2015-06-14 11:46 ` Ian Campbell
2015-06-14 17:21 ` Hans de Goede
2015-06-14 10:40 ` [U-Boot] [PATCH 2/2] sunxi: musb: Remove unused sunxi_musb_exit method Hans de Goede
2015-06-14 11:47 ` Ian Campbell [this message]
2015-06-15 19:21 ` [U-Boot] [PATCH 0/2] sunxi: musb: Fix "usb reset" handling Paul Kocialkowski
2015-06-17 13:39 ` Hans de Goede
2015-06-19 9:11 ` Paul Kocialkowski
2015-06-19 12:35 ` Marek Vasut
2015-06-19 13:07 ` Hans de Goede
2015-06-19 13:08 ` Marek Vasut
2015-06-26 10:20 ` Maxime Ripard
2015-06-26 11:01 ` Hans de Goede
2015-06-28 20:42 ` Maxime Ripard
2015-06-26 11:02 ` Hans de Goede
2015-06-26 11:11 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434282464.29215.9.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox